[PATCH 1/1] git-rebase--interactive.sh: fix trailing spaces on empty $todo

When issuing interactive rebase, git will open a text editor with list of commits to rebase and documentation on how to edit it. At the end of documentation it display, # However, if you remove everything, the rebase will be aborted. # #\t # Note that empty commits are commented out

[PATCH 0/1] git-rebase--interactive.sh: fix trailing spaces on empty $todo

The character "\t" in above example is white space tab. The "make test" was run succesfully but I can't reproduce/test manually with non-empty $todo (I have no idea how to do it). Shulhan (1): git-rebase--interactive.sh: fix trailing spaces on empty $todo git-rebase-

[PATCH v3] builtin/remote: quote remote name on error to display empty name

r messages consistent, quote the name of the remote that we tried and failed to find. Signed-off-by: Shulhan Reviewed-by: Junio C Hamano --- builtin/remote.c | 6 +++--- t/t5505-remote.sh | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/builtin/remote.c b/builtin/remo

Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name

On Thu, 13 Sep 2018 14:51:56 -0700 Junio C Hamano wrote: > Shulhan writes: > > > When adding new remote name with empty string, git will print the > > following error message, > > > > fatal: '' is not a valid remote name\n > > > > But when

[PATCH v2] builtin/remote: quote remote name on error to display empty name

r messages consistent, quote the name of the remote that we tried and failed to find. Signed-off-by: Shulhan Reviewed-by: Junio C Hamano --- builtin/remote.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builtin/remote.c b/builtin/remote.c index 40c6f8a1b..f7edf7f2c 10

[RFC PATCH 1/1] builtin/remote: quote remote name on error to display empty name

Rationale: consistent error format When adding new remote name with empty string, git will print the following error message, fatal: '' is not a valid remote name\n But when removing remote name with empty string as input, git did not print the empty string with quote, fatal: No such remote

[RFC PATCH 0/1] builtin/remote: quote remote name on error to display empty name

l: No such remote: \n Follow up question: If this is ok, should the po files also updated? This is my first patch, sorry if I did some mistakes. Shulhan (1): builtin/remote: quote remote name on error to display empty name builtin/remote.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [bug] Multiline value should error if the next line is section

On Sun, 6 May 2018 22:03:10 +0200 Martin Ågren wrote: > Hi Shulhan > > Thank you for your report. I'm abbreviating a bit: > > On 6 May 2018 at 21:03, Shulhan wrote: > > [alias] > > tree = --no-pager log --graph \ > > -n 20 \

[bug] Multiline value should error if the next line is section

unc) %an %Creset%m %h %s %Cgreen%d%Creset' \ --exclude="*/production" \ --exclude="*/dev-*" \ -n 20 \ [user] name = Shulhan email = m...@kilabit.info ``` (2) Run `git config -f git.config -l` ## Expected Resul