RE: Is finalize_object_file in sha1_file.c handling errno from "rename" correctly?

bject_file to better handle the case of an existing file when renaming. Wesley Smith T: 503.597.0556 | wsm...@greatergiving.com -Original Message- From: Junio C Hamano [mailto:gits...@pobox.com] Sent: Thursday, September 14, 2017 11:51 PM To: Wesley Smith Cc: git@vger.kernel.org S

Is finalize_object_file in sha1_file.c handling errno from "rename" correctly?

ble, whereas "rename" will return EACCESS in this case. Is that correct? If so, should finalize_object_file be fixed to account for this? Perhaps it should check if the newfile exists before calling rename. Or, should the Windows mingw_rename function be modified to return EEXIST in this case, even though that's not the standard errno for that situation? Thanks for your help, Wesley Smith