ing the footnoteref syntax to refer to
the previous footnote potentially makes this a little less readable for
plain text users, although it also reduces duplication. I'm not sure I
feel strongly one way or the other on this.
Otherwise, this looked fine to me.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
ignment problem. This is the
Jonker-Volgenant algorithm, which solves the same problem. It's faster,
but less tolerant.
At least this is what I just learned after about ten minutes of
searching.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
-from-scratch
That would be simpler. You read my mind: I needed some script to make
the sequence editor work, but anything would be fine.
> > + test_config sequence.editor \""$PWD"/replace-editor.sh\" &&
> > + test_tick &&
> > + git rebase -i -r A
a minimal, faithful conversion.
I have no objection to named footnotes and I agree they're easier to use
if we have a large number of them. I think whatever we use, we should
try to make them unique, as I mentioned above.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
length to be
equivalent to GIT_SHA1_RAWSZ, which isn't correct, since what we are
reading is a hex object ID. Instead, check for the length being
equivalent to that of a hex object ID. Use the_hash_algo so this code
works regardless of the hash size.
Signed-off-by: brian m. carlson
---
I noticed
bject-id-part14 series to
make that conversion.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
in
the future, we can add a prerequisite that looks in the module directory
for the appropriate module. We haven't seen an issue with it yet,
though, TTBOMK.
[0]
https://www.iana.org/assignments/http-parameters/http-parameters.xml#content-coding
--
brian m. carlson: Houston, Texas, US
OpenPGP: htt
On Tue, May 22, 2018 at 03:08:26PM -0700, Jonathan Nieder wrote:
> These commits use author Brian M. Carlson <sand...@crustytoothpaste.net>.
> Previously they matched
>
> brian m. carlson <sand...@crustytoothpaste.ath.cx>
> <sand...@crustytoothpaste.net>
ion in order to progress, but I need to
do some research and testing in order to have sufficient facts to
present to the list.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4022-diff-rewrite.sh | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t4022-diff-rewrite.sh b/t/t402
We typically indent our tests with a single tab, partially so that we
can take advantage of indented heredocs. Make this change and move the
quote marks to be in the typical position for our tests.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4029-diff-trailing-sp
of the object ID.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4205-log-pretty-formats.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh
index 591f35daaf..2052cadb11 100755
--- a/t/t42
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4030-diff-textconv.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/t4030-diff-textconv.sh b/t/t403
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t5300-pack-object.sh | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/t/t5300-pack-object.sh b/t
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4045-diff-relative.sh | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t4045-diff-relative.sh b/t
Adjust the test so that it uses variables and command substitution for
trees instead of hard-coded hashes. This also has the benefit of making
it more obvious how the test works.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t3103-ls-tree-misc.sh | 3 ++-
1 file c
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4042-diff-textconv-caching.sh | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/t/t404
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4008-diff-break-rewrite.sh | 59 +++
1 file changed, 32 insertions(+), 27 deletions(-)
diff --g
Adjust the test code so that it computes variables for blobs instead of
using hard-coded hashes. This makes t4033 and t4050 (the patience and
histogram tests) pass.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/lib-diff-alternative.sh | 12
1 file chan
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4029-diff-trailing-space.sh | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/t/t4029-diff-trailing-spac
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4208-log-magic-pathspec.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t4208-log-magic-pathspe
Adjust the test so that it computes variables for blobs and uses the
ZERO_OID variable instead of using hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4007-rename-3.sh | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t3905-stash-include-untracked.sh | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/t/t3905-stash-i
Adjust the test so that it computes values for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4014-format-patch.sh | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/t/t4014-format-patch.sh b/t
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4020-diff-external.sh | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/t/t4020-diff-external.
Strip out the index lines in the diff before comparing them, as these
will differ between hash algorithms. This leads to a smaller, simpler
change than editing the index line.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t3702-add-edit.sh | 7 +++
1 file chan
These tests rely on creating packs with specially named objects which
are necessarily dependent on the hash used. Skip these tests if we're
not using SHA-1.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t5308-pack-detect-duplicates.sh | 6 ++
t/t5309-pack
This test relies on objects with colliding short names which are
necessarily dependent on the hash used. Skip the test if we're not
using SHA-1.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t1512-rev-parse-disambiguation.sh | 6 ++
1 file changed, 6 inse
"slink_id" for consistency
while still preserving alignment.
* Restore blank line between tests.
tbdiff output below.
brian m. carlson (28):
t/test-lib: add an SHA1 prerequisite
t/test-lib: introduce ZERO_OID
t: switch $_z40 to $ZERO_OID
t/test-lib: introduce OID_REGEX
t: switch
This test relies on objects with colliding short names which are
necessarily dependent on the hash used. Skip the test if we're not
using SHA-1.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4044-diff-index-unique-abbrev.sh | 6 ++
1 file changed, 6 inse
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t2203-add-intent.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t2203-add-intent.sh b/t/t22
Since this is a core test that tests basic functionality, annotate the
assertions that have dependencies on SHA-1 with the appropriate
prerequisite.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t-basic.sh | 24
1 file changed, 12 inse
of these tests which handle both SHA-1 and NewHash.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/test-lib.sh | 7 +++
1 file changed, 7 insertions(+)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index ea2bbaaa7a..fce728d2ea 100644
--- a/t/test-lib.sh
+++ b/t/test-
Switch all uses of $_x40 to $OID_REGEX so that they work correctly with
larger hashes. This commit was created by using the following sed
command to modify all files in the t directory except t/test-lib.sh:
sed -i 's/\$_x40/$OID_REGEX/g'
Signed-off-by: brian m. carlson <s
Since this is a core test that tests basic functionality, annotate the
assertions that have dependencies on SHA-1 with the appropriate
prerequisite.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t1007-hash-object.sh | 16
1 file changed, 8 insertions
a regex matching the appropriate object ID, regardless of
the length of the current hash.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/test-lib.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 58c2ea52c6..fed2
Switch all uses of $_z40 to $ZERO_OID so that they work correctly with
larger hashes. This commit was created by using the following sed
command to modify all files in the t directory except t/test-lib.sh:
sed -i 's/\$_z40/$ZERO_OID/g'
Signed-off-by: brian m. carlson <s
ID, regardless of the length of the current hash.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/test-lib.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index fce728d2ea..58c2ea52c6 100644
--- a/t/test-lib.sh
+
e been updated
> to test the moral equivalent of the original without hardcoding the
> actual object names.
>
> Will merge to 'next'.
I think there was one minor change Stefan wanted out of this series.
I'll send a reroll (and tbdiff) with just that change.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
s in
command line options over specifically concerns about the use of egrep
itself. I suspect the implementations that want egrep over grep -E (the
latter being POSIX) also lack many of the POSIX options that people want
to use, although I'm not aware of egrep itself being broken anywhere.
--
brian
On Wed, May 16, 2018 at 09:56:33AM -0700, Stefan Beller wrote:
> Hi brian,
>
> On Tue, May 15, 2018 at 6:56 PM, brian m. carlson
> <sand...@crustytoothpaste.net> wrote:
> For the 2 occurrences above I think the SHA1 requirement is not
> needed as the check if a blob exi
Adjust the test so that it computes variables for blobs and uses the
ZERO_OID variable instead of using hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4007-rename-3.sh | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff
We typically indent our tests with a single tab, partially so that we
can take advantage of indented heredocs. Make this change and move the
quote marks to be in the typical position for our tests.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4029-diff-trailing-sp
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4020-diff-external.sh | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/t/t4020-diff-external.
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4022-diff-rewrite.sh | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t4022-diff-rewrite.sh b/t/t402
Strip out the index lines in the diff before comparing them, as these
will differ between hash algorithms. This leads to a smaller, simpler
change than editing the index line.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t3702-add-edit.sh | 7 +++
1 file chan
Adjust the test so that it uses variables and command substitution for
trees instead of hard-coded hashes. This also has the benefit of making
it more obvious how the test works.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t3103-ls-tree-misc.sh | 3 ++-
1 file c
This test relies on objects with colliding short names which are
necessarily dependent on the hash used. Skip the test if we're not
using SHA-1.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t1512-rev-parse-disambiguation.sh | 6 ++
1 file changed, 6 inse
Since this is a core test that tests basic functionality, annotate the
assertions that have dependencies on SHA-1 with the appropriate
prerequisite.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t-basic.sh | 24
1 file changed, 12 inse
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4008-diff-break-rewrite.sh | 59 +++
1 file changed, 32 insertions(+), 27 deletions(-)
diff --g
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4042-diff-textconv-caching.sh | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/t/t404
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4030-diff-textconv.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/t4030-diff-textconv.sh b/t/t403
of the object ID.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4205-log-pretty-formats.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh
index 591f35daaf..2052cadb11 100755
--- a/t/t42
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t5300-pack-object.sh | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/t/t5300-pack-object.sh b/t
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4045-diff-relative.sh | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t4045-diff-relative.sh b/t
Adjust the test code so that it computes variables for blobs instead of
using hard-coded hashes. This makes t4033 and t4050 (the patience and
histogram tests) pass.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/lib-diff-alternative.sh | 12
1 file chan
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4208-log-magic-pathspec.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t4208-log-magic-pathspe
Adjust the test so that it computes values for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4014-format-patch.sh | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/t/t4014-format-patch.sh b/t
preserving alignment.
* Restore blank line between tests.
tbdiff output below.
brian m. carlson (28):
t/test-lib: add an SHA1 prerequisite
t/test-lib: introduce ZERO_OID
t: switch $_z40 to $ZERO_OID
t/test-lib: introduce OID_REGEX
t: switch $_x40 to $OID_REGEX
t: annotate with SHA1
Since this is a core test that tests basic functionality, annotate the
assertions that have dependencies on SHA-1 with the appropriate
prerequisite.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t1007-hash-object.sh | 16
1 file changed, 8 insertions
ID, regardless of the length of the current hash.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/test-lib.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index fce728d2ea..58c2ea52c6 100644
--- a/t/test-lib.sh
+
These tests rely on creating packs with specially named objects which
are necessarily dependent on the hash used. Skip these tests if we're
not using SHA-1.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t5308-pack-detect-duplicates.sh | 6 ++
t/t5309-pack
a regex matching the appropriate object ID, regardless of
the length of the current hash.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/test-lib.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 58c2ea52c6..fed2
Switch all uses of $_z40 to $ZERO_OID so that they work correctly with
larger hashes. This commit was created by using the following sed
command to modify all files in the t directory except t/test-lib.sh:
sed -i 's/\$_z40/$ZERO_OID/g'
Signed-off-by: brian m. carlson <s
This test relies on objects with colliding short names which are
necessarily dependent on the hash used. Skip the test if we're not
using SHA-1.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4044-diff-index-unique-abbrev.sh | 6 ++
1 file changed, 6 inse
of these tests which handle both SHA-1 and NewHash.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/test-lib.sh | 7 +++
1 file changed, 7 insertions(+)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index ea2bbaaa7a..fce728d2ea 100644
--- a/t/test-lib.sh
+++ b/t/test-
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4029-diff-trailing-space.sh | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/t/t4029-diff-trailing-spac
Switch all uses of $_x40 to $OID_REGEX so that they work correctly with
larger hashes. This commit was created by using the following sed
command to modify all files in the t directory except t/test-lib.sh:
sed -i 's/\$_x40/$OID_REGEX/g'
Signed-off-by: brian m. carlson <s
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t2203-add-intent.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t2203-add-intent.sh b/t/t22
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t3905-stash-include-untracked.sh | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/t/t3905-stash-i
On Sun, May 13, 2018 at 09:34:03AM +0200, Johannes Sixt wrote:
> Am 13.05.2018 um 04:24 schrieb brian m. carlson:
> > diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> > index dac3f349a3..42b3e11207 100755
> > --- a/t/t4014-format-patch.sh
> > ++
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4008-diff-break-rewrite.sh | 59 +++
1 file changed, 32 insertions(+), 27 deletions(-)
diff --g
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t3905-stash-include-untracked.sh | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/t/t3905-stash-i
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4042-diff-textconv-caching.sh | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/t/t404
of the object ID.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4205-log-pretty-formats.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh
index 591f35daaf..2052cadb11 100755
--- a/t/t42
Adjust the test code so that it computes variables for blobs instead of
using hard-coded hashes. This makes t4033 and t4050 (the patience and
histogram tests) pass.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/lib-diff-alternative.sh | 12
1 file chan
Adjust the test so that it computes values for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4014-format-patch.sh | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/t/t4014-format-patch.sh b/t/t4014-
Strip out the index lines in the diff before comparing them, as these
will differ between hash algorithms. This leads to a smaller, simpler
change than editing the index line.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t3702-add-edit.sh | 7 +++
1 file chan
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4208-log-magic-pathspec.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t4208-log-magic-pathspe
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4020-diff-external.sh | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/t/t4020-diff-external.sh b/t
We typically indent our tests with a single tab, partially so that we
can take advantage of indented heredocs. Make this change and move the
quote marks to be in the typical position for our tests.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4029-diff-trailing-sp
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4029-diff-trailing-space.sh | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/t/t4029-diff-trailing-space.
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4045-diff-relative.sh | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t4045-diff-relative.sh b/t
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t2203-add-intent.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t2203-add-intent.sh b/t/t22
This test relies on objects with colliding short names which are
necessarily dependent on the hash used. Skip the test if we're not
using SHA-1.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t1512-rev-parse-disambiguation.sh | 6 ++
1 file changed, 6 inse
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4022-diff-rewrite.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/t4022-diff-rewrite.sh b/t/t402
These tests rely on creating packs with specially named objects which
are necessarily dependent on the hash used. Skip these tests if we're
not using SHA-1.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t5308-pack-detect-duplicates.sh | 6 ++
t/t5309-pack
Since this is a core test that tests basic functionality, annotate the
assertions that have dependencies on SHA-1 with the appropriate
prerequisite.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t-basic.sh | 24
1 file changed, 12 inse
This test relies on objects with colliding short names which are
necessarily dependent on the hash used. Skip the test if we're not
using SHA-1.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4044-diff-index-unique-abbrev.sh | 6 ++
1 file changed, 6 inse
Since this is a core test that tests basic functionality, annotate the
assertions that have dependencies on SHA-1 with the appropriate
prerequisite.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t1007-hash-object.sh | 16
1 file changed, 8 insertions
Adjust the test so that it computes variables for blobs instead of using
hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4030-diff-textconv.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/t4030-diff-textconv.sh b/t/t403
Adjust the test so that it uses variables and command substitution for
trees instead of hard-coded hashes. This also has the benefit of making
it more obvious how the test works.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t3103-ls-tree-misc.sh | 3 ++-
1 file c
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t5300-pack-object.sh | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/t/t5300-pack-object.sh b/t
Adjust the test so that it computes variables for blobs and uses the
ZERO_OID variable instead of using hard-coded hashes.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/t4007-rename-3.sh | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff
a regex matching the appropriate object ID, regardless of
the length of the current hash.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/test-lib.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 58c2ea52c6..fed2
Switch all uses of $_z40 to $ZERO_OID so that they work correctly with
larger hashes. This commit was created by using the following sed
command to modify all files in the t directory except t/test-lib.sh:
sed -i 's/\$_z40/$ZERO_OID/g'
Signed-off-by: brian m. carlson <s
Switch all uses of $_x40 to $OID_REGEX so that they work correctly with
larger hashes. This commit was created by using the following sed
command to modify all files in the t directory except t/test-lib.sh:
sed -i 's/\$_x40/$OID_REGEX/g'
Signed-off-by: brian m. carlson <s
ID, regardless of the length of the current hash.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/test-lib.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index fce728d2ea..58c2ea52c6 100644
--- a/t/test-lib.sh
+
* Restore blank line between tests.
tbdiff output below.
brian m. carlson (28):
t/test-lib: add an SHA1 prerequisite
t/test-lib: introduce ZERO_OID
t: switch $_z40 to $ZERO_OID
t/test-lib: introduce OID_REGEX
t: switch $_x40 to $OID_REGEX
t: annotate with SHA1 prerequisite
t1007
of these tests which handle both SHA-1 and NewHash.
Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net>
---
t/test-lib.sh | 7 +++
1 file changed, 7 insertions(+)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index ea2bbaaa7a..fce728d2ea 100644
--- a/t/test-lib.sh
+++ b/t/test-
401 - 500 of 2261 matches
Mail list logo
