[PATCH] git-p4: format-patch to diff-tree change breaks binary patches

message git-apply emits in this case: error: cannot apply binary patch to 'filename' without full index line error: filename: patch does not apply Signed-off-by: Tolga Ceylan tolga.cey...@gmail.com Acked-by: Pete Wyckoff p...@padd.com --- git-p4.py |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches

This is the error message git-apply emits in this case: error: cannot apply binary patch to 'filename' without full index line error: filename: patch does not apply Cheers, Tolga Any feedback is appreciated. Cheers, Tolga -- To unsubscribe from this list: send the line unsubscribe git in

Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches

patches a full index is required. format-patch already handles this, but diff-tree needs '--full-index' argument to always output full index. Signed-off-by: Tolga Ceylan tolga.cey...@gmail.com --- git-p4.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-p4.py b/git-p4

Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches

On 04/26/2014 02:12 PM, tolga ceylan wrote: Yes, when git-p4 runs git-apply to test the patch, this fails due to abbreviated blob object names. I think git-apply requires full object names for binary patches. This looks like a straightforward change, but can you give a bit more background

[PATCH] git-p4: format-patch to diff-tree change breaks binary patches

When applying binary patches a full index is required. format-patch already handles this, but diff-tree needs '--full-index' argument to always output full index. Signed-off-by: Tolga Ceylan tolga.cey...@gmail.com --- git-p4.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git