On Fri, Jun 09, 2017 at 07:19:35PM -0400, Jeff King wrote:
> Should "git add" check whether there's a matching .gitmodules entry for
> the path and issue a warning otherwise?
Here's my attempt at that.
[1/2]: add: warn when adding an embedded repository
[2/2]: t: move "git add submodule" int
On Fri, Jun 9, 2017 at 7:10 PM, Junio C Hamano wrote:
> Jeff King writes:
>
>> In an ideal world the user do:
>>
>> git submodule add git://host/repo.git path
>>
>> which adds the gitlink and the .gitmodules entry. But it doesn't seem
>> unreasonable for somebody unfamiliar with submodules to d
Jeff King writes:
> Certainly I think it _could_ be a valid state. But traditionally it
> caused "clone --recursive" to barf. And from what Stefan and Brandon
> have said, we are moving in the opposite direction entirely, with
> .gitmodules becoming the source of truth.
>
> I could see arguments
On Sat, Jun 10, 2017 at 11:10:11AM +0900, Junio C Hamano wrote:
> Jeff King writes:
>
> > In an ideal world the user do:
> >
> > git submodule add git://host/repo.git path
> >
> > which adds the gitlink and the .gitmodules entry. But it doesn't seem
> > unreasonable for somebody unfamiliar wit
Jeff King writes:
> In an ideal world the user do:
>
> git submodule add git://host/repo.git path
>
> which adds the gitlink and the .gitmodules entry. But it doesn't seem
> unreasonable for somebody unfamiliar with submodules to do:
>
> git clone git://host/repo.git path
> git add path
>
>
On Tue, Jun 06, 2017 at 02:39:14PM -0400, Jeff King wrote:
> > Just for some background on the new behavior and how this functionality
> > changed: My series changed how 'submodule init' behaved if you have
> > 'submodule.active' set. Once set (like how clone --recurse does now)
> > when not prov
On Tue, Jun 06, 2017 at 11:10:24AM -0700, Brandon Williams wrote:
> > > This bisects to your bb62e0a99 (clone: teach --recurse-submodules to
> > > optionally take a pathspec, 2017-03-17). That patch just sets
> > > submodule.active by default, so I think the real issue is probably in
> > > a086f92
On 06/06, Stefan Beller wrote:
> On Mon, Jun 5, 2017 at 8:56 PM, Jeff King wrote:
> > While running some regression tests with v2.13, I noticed an odd
> > behavior. If I create a repository where there's a gitlink with no
> > matching .gitmodules entry:
> >
> > git init repo
> > cd repo
> >
On Mon, Jun 5, 2017 at 8:56 PM, Jeff King wrote:
> While running some regression tests with v2.13, I noticed an odd
> behavior. If I create a repository where there's a gitlink with no
> matching .gitmodules entry:
>
> git init repo
> cd repo
> n10=1234abcdef
> n40=$n10$n10$n10$n10
> git
While running some regression tests with v2.13, I noticed an odd
behavior. If I create a repository where there's a gitlink with no
matching .gitmodules entry:
git init repo
cd repo
n10=1234abcdef
n40=$n10$n10$n10$n10
git update-index --add --cacheinfo 16 $n40 foo
git commit -m "gi
10 matches
Mail list logo
