[PATCH v2 0/3] Re: [BUG] "git stash -- path" reports wrong unstaged changes

2017-03-21 Thread Thomas Gummerer
Thanks Junio and Peff for comments and suggestions on the previous round. Changes since v1: - 1/3 now contains the changes that were previously split up into 1/3 and 2/3, and also makes git reset --hard in the simple 'git stash' case quiet unconditionally. - 2/3 is what was 3/3 in the

Re: [BUG] "git stash -- path" reports wrong unstaged changes

2017-03-20 Thread Jeff King
On Sat, Mar 18, 2017 at 06:36:58PM +, Thomas Gummerer wrote: > > + if test -z "$GIT_QUIET" && ! git diff-files --quiet > > + then > > + say "$(gettext "Unstaged changes after reset:")" > > + git diff-files

Re: [BUG] "git stash -- path" reports wrong unstaged changes

2017-03-19 Thread Thomas Gummerer
This series implements my proposal for fixing bug in git stash -- , plus the two other things I noticed while looking at the code. > I think one option would be to to just keep quiet about the exact > changes that git stash push makes, similar to what we do in the > --include-untracked and in the

Re: [BUG] "git stash -- path" reports wrong unstaged changes

2017-03-18 Thread Thomas Gummerer
On 03/17, Jeff King wrote: > I used "git stash -- path" for the first time today and happened to > notice an oddity. If I run: > > git init -q repo > cd repo > > for i in one two; do > echo content >$i > git add $i > done > git

[BUG] "git stash -- path" reports wrong unstaged changes

2017-03-17 Thread Jeff King
I used "git stash -- path" for the first time today and happened to notice an oddity. If I run: git init -q repo cd repo for i in one two; do echo content >$i git add $i done git commit -qm base for