Re: [GSoC][PATCH 5/6 v2] submodule: port submodule subcommand sync from shell to C

On Tue, Jun 27, 2017 at 1:11 AM, Prathamesh Chavan wrote: > +static char *get_up_path(const char *path) > +{ > + int i = count_slashes(path); > + int l = strlen(path); Nit: "l" is quite similar to "i" in many fonts, so maybe use "len" instead of "l", but see

[GSoC][PATCH 5/6 v2] submodule: port submodule subcommand sync from shell to C

The mechanism used for porting the submodule subcommand 'sync' is similar to that of 'foreach', where we split the function cmd_sync from shell into three functions in C, module_sync, for_each_submodule_list and sync_submodule. print_default_remote is introduced as a submodule--helper subcommand