Re: [GSoC][PATCH v2 2/7] rebase--interactive: rewrite append_todo_help() in C

2018-07-03 Thread Junio C Hamano
Alban Gruin writes: > + ret = fputs(buf.buf, todo); > + if (ret < 0) > + error_errno(_("Could not append help text to '%s'"), > rebase_path_todo()); Error checking fputs() return is an improvement from the version that has been queued on 'pu'. I think messages given to

[GSoC][PATCH v2 2/7] rebase--interactive: rewrite append_todo_help() in C

2018-07-02 Thread Alban Gruin
This rewrites append_todo_help() from shell to C. It also incorporates some parts of initiate_action() and complete_action() that also write help texts to the todo file. This also introduces the source file rebase-interactive.c. This file will contain functions necessary for interactive rebase