Re: [GSoC][PATCH v4] Make options that expect object ids less chatty if id is invalid

2018-03-19 Thread ungureanupaulsebastian
Hello, Thank you for your advice! Soon enough, I wil submit a new patch which fixes the issues you mentioned. Best regards, Paul Ungureanu

Re: [GSoC][PATCH v4] Make options that expect object ids less chatty if id is invalid

2018-03-08 Thread Martin Ă…gren
Hi Paul-Sebastian On 6 March 2018 at 20:31, Paul-Sebastian Ungureanu wrote: > Usually, the usage should be shown only if the user does not know what > options are available. If the user specifies an invalid value, the user > is already aware of the available

Re: [GSoC][PATCH v4] Make options that expect object ids less chatty if id is invalid

2018-03-06 Thread Junio C Hamano
Junio C Hamano writes: > I kind of find it surprising that the one single case I happened to > have noticed is the only one that needed special treatment. Did you > go though all the codepath and made sure that the ones that still > return -1 (not -2 and not -3) to

Re: [GSoC][PATCH v4] Make options that expect object ids less chatty if id is invalid

2018-03-06 Thread Junio C Hamano
Paul-Sebastian Ungureanu writes: > Usually, the usage should be shown only if the user does not know what > options are available. If the user specifies an invalid value, the user > is already aware of the available options. In this case, there is no > point in

[GSoC][PATCH v4] Make options that expect object ids less chatty if id is invalid

2018-03-06 Thread Paul-Sebastian Ungureanu
Usually, the usage should be shown only if the user does not know what options are available. If the user specifies an invalid value, the user is already aware of the available options. In this case, there is no point in displaying the usage anymore. This patch applies to "git tag --contains",