Re: [GSoC][PATCH v8 14/20] stash: convert create to builtin

2018-11-09 Thread Johannes Schindelin
Hi Paul, On Wed, 26 Sep 2018, Paul-Sebastian Ungureanu wrote: > Sorry for the late reply. I had a lot on my plate for the last couple of > weeks. I understand. University can be busy times. > > > + > > > + git_config(git_diff_basic_config, NULL); > > > > Is this not called in as part of

Re: [GSoC][PATCH v8 14/20] stash: convert create to builtin

2018-09-25 Thread Paul-Sebastian Ungureanu
Hi, Sorry for the late reply. I had a lot on my plate for the last couple of weeks. + + git_config(git_diff_basic_config, NULL); Is this not called in as part of `git_config(git_default_config, NULL);` in cmd_stash() already? *clicketyclick* I guess not. But then, maybe it would

Re: [GSoC][PATCH v8 14/20] stash: convert create to builtin

2018-09-03 Thread Johannes Schindelin
Hi Paul, On Fri, 31 Aug 2018, Paul-Sebastian Ungureanu wrote: > diff --git a/builtin/stash--helper.c b/builtin/stash--helper.c > index 87568b0f34..ce360a569d 100644 > --- a/builtin/stash--helper.c > +++ b/builtin/stash--helper.c > @@ -290,6 +296,18 @@ static int reset_head(void) > return

[GSoC][PATCH v8 14/20] stash: convert create to builtin

2018-08-30 Thread Paul-Sebastian Ungureanu
Add stash create to the helper. Signed-off-by: Paul-Sebastian Ungureanu --- builtin/stash--helper.c | 430 git-stash.sh| 2 +- 2 files changed, 431 insertions(+), 1 deletion(-) diff --git a/builtin/stash--helper.c b/builtin/stash--helper.c