Re: [GSoC][PATCH v8 18/20] stash: convert `stash--helper.c` into `stash.c`

2018-11-09 Thread Johannes Schindelin
Hi Paul, On Wed, 26 Sep 2018, Paul-Sebastian Ungureanu wrote: > Hi, > > > > @@ -1443,9 +1448,10 @@ static int push_stash(int argc, const char > > > **argv, const char *prefix) > > > OPT_END() > > >}; > > > - argc = parse_options(argc, argv, prefix, options, > > > -

Re: [GSoC][PATCH v8 18/20] stash: convert `stash--helper.c` into `stash.c`

2018-09-25 Thread Paul-Sebastian Ungureanu
Hi, @@ -1443,9 +1448,10 @@ static int push_stash(int argc, const char **argv, const char *prefix) OPT_END() }; - argc = parse_options(argc, argv, prefix, options, -git_stash_helper_push_usage, -0); + if

Re: [GSoC][PATCH v8 18/20] stash: convert `stash--helper.c` into `stash.c`

2018-09-03 Thread Johannes Schindelin
Hi Paul, On Fri, 31 Aug 2018, Paul-Sebastian Ungureanu wrote: > diff --git a/builtin/stash--helper.c b/builtin/stash.c > similarity index 90% > rename from builtin/stash--helper.c > rename to builtin/stash.c > index 1269f2548c..3d2316e3f7 100644 > --- a/builtin/stash--helper.c > +++

[GSoC][PATCH v8 18/20] stash: convert `stash--helper.c` into `stash.c`

2018-08-30 Thread Paul-Sebastian Ungureanu
The old shell script `git-stash.sh` was removed and replaced entirely by `builtin/stash.c`. In order to do that, `create` and `push` were adapted to work without `stash.sh`. For example, before this commit, `git stash create` called `git stash--helper create --message "$*"`. If it called `git