Re: [GSoC14][RFC] Proposal Draft: Refactor tempfile handling

2014-03-12 Thread Brian Gesiak
> Currently the linked list of lockfiles only grows, never shrinks. Once > an object has been linked into the list, there is no way to remove it > again even after the lock has been released. So if a lock needs to be > created dynamically at a random place in the code, its memory is > unavoidably

Re: [GSoC14][RFC] Proposal Draft: Refactor tempfile handling

2014-03-11 Thread Jeff King
On Tue, Mar 11, 2014 at 05:27:05PM +0100, Michael Haggerty wrote: > Thanks for your proposal. I have a technical point that I think your > proposal should address: > > Currently the linked list of lockfiles only grows, never shrinks. Once > an object has been linked into the list, there is no w

Re: [GSoC14][RFC] Proposal Draft: Refactor tempfile handling

2014-03-11 Thread Michael Haggerty
On 03/01/2014 10:04 PM, Brian Gesiak wrote: > Hello all, > > My name is Brian Gesiak. I'm a research student at the University of > Tokyo, and I'm hoping to participate in this year's Google Summer of > Code by contributing to Git. I'm a longtime user, first-time > contributor--some of you may hav

Re: [GSoC14][RFC] Proposal Draft: Refactor tempfile handling

2014-03-10 Thread Jeff King
On Sun, Mar 09, 2014 at 02:04:16AM +0900, Brian Gesiak wrote: > > Once the logic is extracted into a nice API, there are > > several other places that can use it, too: ... > > I've found the following four areas so far: > > 1. lockfile.lock_file > 2. git-compat-util.odb_mkstemp > 3. git-compat-u

Re: [GSoC14][RFC] Proposal Draft: Refactor tempfile handling

2014-03-08 Thread Brian Gesiak
Excellent, thank you very much for the feedback, Jeff! It was very helpful and encouraging. I've done some more research based on your comments. > Once the logic is extracted into a nice API, there are > several other places that can use it, too: ... I've found the following four areas so far: 1

Re: [GSoC14][RFC] Proposal Draft: Refactor tempfile handling

2014-03-03 Thread Jeff King
On Sun, Mar 02, 2014 at 06:04:39AM +0900, Brian Gesiak wrote: > My name is Brian Gesiak. I'm a research student at the University of > Tokyo, and I'm hoping to participate in this year's Google Summer of > Code by contributing to Git. I'm a longtime user, first-time > contributor--some of you may

[GSoC14][RFC] Proposal Draft: Refactor tempfile handling

2014-03-01 Thread Brian Gesiak
Hello all, My name is Brian Gesiak. I'm a research student at the University of Tokyo, and I'm hoping to participate in this year's Google Summer of Code by contributing to Git. I'm a longtime user, first-time contributor--some of you may have noticed my "microproject" patches.[1][2] I'd like to