Seems were getting closer, some comments from a quick read of your
patch below.
Am 26.03.2013 05:03, schrieb Eric Cousineau:
From 2c2923ada809d671828aa58dcda05a1b71222b70 Mon Sep 17 00:00:00 2001
From: Eric Cousineau eacousin...@gmail.com
Date: Mon, 25 Mar 2013 22:27:06 -0500
Subject: [PATCH]
On 03/18/2013 04:10 PM, Jens Lehmann wrote:
Am 12.03.2013 17:01, schrieb Phil Hord:
On Sat, Mar 9, 2013 at 1:18 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 05.03.2013 22:17, schrieb Phil Hord:
On Tue, Mar 5, 2013 at 3:51 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 05.03.2013 19:34,
From 2c2923ada809d671828aa58dcda05a1b71222b70 Mon Sep 17 00:00:00 2001
From: Eric Cousineau eacousin...@gmail.com
Date: Mon, 25 Mar 2013 22:27:06 -0500
Subject: [PATCH] submodule-foreach: Added in --post-order=command and
adjusted code per Jens Lehmann's suggestion
Signed-off-by: Eric Cousineau
On 03/25/2013 10:56 PM, Eric Cousineau wrote:
On 03/18/2013 04:10 PM, Jens Lehmann wrote:
Am 12.03.2013 17:01, schrieb Phil Hord:
On Sat, Mar 9, 2013 at 1:18 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 05.03.2013 22:17, schrieb Phil Hord:
...
I agree on the possible problems a
Jens Lehmann jens.lehm...@web.de writes:
Am 12.03.2013 17:01, schrieb Phil Hord:
On Sat, Mar 9, 2013 at 1:18 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 05.03.2013 22:17, schrieb Phil Hord:
On Tue, Mar 5, 2013 at 3:51 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 05.03.2013 19:34,
Junio C Hamano gits...@pobox.com writes:
Jens Lehmann jens.lehm...@web.de writes:
...
I totally agree with that. First, adding --include-super does not
belong into the --post-order patch at all, as that is a different
topic (even though it belongs to the same use case Eric has).
I forgot to
Am 12.03.2013 17:01, schrieb Phil Hord:
On Sat, Mar 9, 2013 at 1:18 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 05.03.2013 22:17, schrieb Phil Hord:
On Tue, Mar 5, 2013 at 3:51 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 05.03.2013 19:34, schrieb Junio C Hamano:
Eric Cousineau
Thanks, just a quick review before I find some time do take a
deeper look.
Am 14.03.2013 07:30, schrieb Eric Cousineau:
From 59fb432e17a1aae9de26bbaaca7f09cc7f03b471 Mon Sep 17 00:00:00 2001
From: Eric Cousineau eacousin...@gmail.com
Date: Thu, 14 Mar 2013 01:19:53 -0500
Subject: [PATCH]
From 59fb432e17a1aae9de26bbaaca7f09cc7f03b471 Mon Sep 17 00:00:00 2001
From: Eric Cousineau eacousin...@gmail.com
Date: Thu, 14 Mar 2013 01:19:53 -0500
Subject: [PATCH] submodule-foreach: Added in --post-order=command per Jens
Lehmann's suggestion
Signed-off-by: Eric Cousineau
On Sat, Mar 9, 2013 at 1:18 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 05.03.2013 22:17, schrieb Phil Hord:
On Tue, Mar 5, 2013 at 3:51 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 05.03.2013 19:34, schrieb Junio C Hamano:
Eric Cousineau eacousin...@gmail.com writes:
...
I am not
On Sat, Mar 09, 2013 at 07:18:48PM +0100, Jens Lehmann wrote:
Am 05.03.2013 22:17, schrieb Phil Hord:
In a shell, it usually goes like this:
git submodule foreach --recursive '${cmd}'
uphomedel{30-ish}endbackspaceenter
It'd be easier if I could just include a switch for this,
Am 05.03.2013 22:17, schrieb Phil Hord:
On Tue, Mar 5, 2013 at 3:51 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 05.03.2013 19:34, schrieb Junio C Hamano:
Eric Cousineau eacousin...@gmail.com writes:
...
I am not entirely convinced we would want --include-super in the
first place, though.
Heiko Voigt hvo...@hvoigt.net writes:
On Mon, Mar 04, 2013 at 03:00:45PM -0800, Junio C Hamano wrote:
So if you want a single boolean to toggle between the current
behaviour and the other one, it would be --post-order. But you may
at least want to consider pros and cons of allowing users to
On Tue, Mar 5, 2013 at 10:09 AM, Junio C Hamano gits...@pobox.com wrote:
Heiko Voigt hvo...@hvoigt.net writes:
On Mon, Mar 04, 2013 at 03:00:45PM -0800, Junio C Hamano wrote:
So if you want a single boolean to toggle between the current
behaviour and the other one, it would be --post-order.
Eric Cousineau eacousin...@gmail.com writes:
Would these be the correct behaviors of Heiko's implementation?
I do not think Heiko already has an implementation, but let's try to
see how each example makes sense.
git submodule foreach # Empty command, pre-order
git submodule foreach
Am 05.03.2013 19:34, schrieb Junio C Hamano:
Eric Cousineau eacousin...@gmail.com writes:
Would these be the correct behaviors of Heiko's implementation?
I do not think Heiko already has an implementation, but let's try to
see how each example makes sense.
git submodule foreach # Empty
On Tue, Mar 5, 2013 at 3:51 PM, Jens Lehmann jens.lehm...@web.de wrote:
Am 05.03.2013 19:34, schrieb Junio C Hamano:
Eric Cousineau eacousin...@gmail.com writes:
...
I am not entirely convinced we would want --include-super in the
first place, though. It does not belong to submodule foreach;
In this patch, foreach --recursive acts depth-first, much like the default
behavior described in the patch by Imram Yousuf in this
post http://marc.info/?l=gitm=121066084508631w=2.
Changes were made so that the submodule Entering ... message was right
next to the output generated by the command
Please don't attach your patches, see Documentation/SubmittingPatches on
how to post patches to this list.
Am 04.03.2013 09:41, schrieb Eric Cousineau:
In this patch, foreach --recursive acts depth-first, much like the default
behavior described in the patch by Imram Yousuf in this
post
git-submodule.sh: In foreach, make '-post-order' yield post-order
traversal and
'--include-super' execute commands at the top-level supermodule, with
both of these
options compatible with '--recursive'.
Signed-off-by: Eric Cousineau eacousin...@gmail.com
---
Sorry about missing the part about
On Mon, Mar 04, 2013 at 03:00:45PM -0800, Junio C Hamano wrote:
So if you want a single boolean to toggle between the current
behaviour and the other one, it would be --post-order. But you may
at least want to consider pros and cons of allowing users to give
two separate commands, one for the
21 matches
Mail list logo
