Re: [PATCH/RFC] blame: respect "core.ignorecase"

2012-09-10 Thread Junio C Hamano
Jeff King writes: > But I would think for that particular use case, you would not want to do > a per-glob prefix for that, but would rather use a command-line switch. Yes. Even though it is not listed as possible future semantics, one thing that we may want to have before all others is ":(negat

Re: [PATCH/RFC] blame: respect "core.ignorecase"

2012-09-10 Thread Jeff King
On Mon, Sep 10, 2012 at 02:38:08PM -0700, Junio C Hamano wrote: > > Thanks, that helped. I got excited when I saw the "icase" in the > > comments and thought it might already be implemented. But it looks like > > it is still to be done. :) > > Yeah, some are tongue-in-cheek (e.g. I do not know wh

Re: [PATCH/RFC] blame: respect "core.ignorecase"

2012-09-10 Thread Junio C Hamano
Jeff King writes: > On Mon, Sep 10, 2012 at 01:30:03PM -0700, Junio C Hamano wrote: > >> Jeff King writes: >> >> > If the proposal were instead to add a certain type of pathspec that is >> > case-insensitive[2], that would make much more sense to me. It is not >> > violating git's case-sensitiv

Re: [PATCH/RFC] blame: respect "core.ignorecase"

2012-09-10 Thread Jeff King
On Mon, Sep 10, 2012 at 01:30:03PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > If the proposal were instead to add a certain type of pathspec that is > > case-insensitive[2], that would make much more sense to me. It is not > > violating git's case-sensitivity because it is purely a _

Re: [PATCH/RFC] blame: respect "core.ignorecase"

2012-09-10 Thread Junio C Hamano
Jeff King writes: > If the proposal were instead to add a certain type of pathspec that is > case-insensitive[2], that would make much more sense to me. It is not > violating git's case-sensitivity because it is purely a _query_ issue. > And it is a feature you might use whether or not your files

Re: [PATCH/RFC] blame: respect "core.ignorecase"

2012-09-10 Thread Jeff King
On Sun, Sep 09, 2012 at 12:24:58PM -0700, Junio C Hamano wrote: > Having said all that, I am not sure if the "fixing" is really the > right approach to begin with. Contrast these two: > > $ git blame MakeFILE > $ git blame HEAD -- MakeFILE > > The latter, regardless of core.ignorecase,

Re: [PATCH/RFC] blame: respect "core.ignorecase"

2012-09-09 Thread Ralf Thielow
On Sun, Sep 9, 2012 at 9:24 PM, Junio C Hamano wrote: > Ralf Thielow writes: > >> If "core.ignorecase" is true, "git blame" fails >> when the given path differs to the real path in case >> sensitivity. > > It is rather hard to respond to this request for comment because you > are describing the b

Re: [PATCH/RFC] blame: respect "core.ignorecase"

2012-09-09 Thread Junio C Hamano
Junio C Hamano writes: > If we were to do anything, I would think the most sane thing to do > is a smaller patch to fix fake_working_tree_commit() where it calls > lstat() and _should_ die with "Cannot lstat MakeFILE" on a sane > filesystem. It does not currently make sure the path exists in the

Re: [PATCH/RFC] blame: respect "core.ignorecase"

2012-09-09 Thread Junio C Hamano
Ralf Thielow writes: > If "core.ignorecase" is true, "git blame" fails > when the given path differs to the real path in case > sensitivity. It is rather hard to respond to this request for comment because you are describing the behaviour you perceive as a problem only fuzzily (i.e. "fails"---wh

Re: [PATCH/RFC] blame: respect "core.ignorecase"

2012-09-09 Thread Johannes Sixt
Am 09.09.2012 19:01, schrieb Ralf Thielow: > If "core.ignorecase" is true, "git blame" fails > when the given path differs to the real path in case > sensitivity. ... > + dir = opendir(res.buf); ... > + struct dirent *ent = readdir(dir

[PATCH/RFC] blame: respect "core.ignorecase"

2012-09-09 Thread Ralf Thielow
If "core.ignorecase" is true, "git blame" fails when the given path differs to the real path in case sensitivity. Signed-off-by: Ralf Thielow --- .gitignore | 1 + Makefile | 3 +++ builtin/blame.c| 58 ++ test-p