Re: [PATCH/RFC 00/10] ref-filter: use parsing functions

2015-12-16 Thread Karthik Nayak
On Mon, Dec 14, 2015 at 3:25 AM, Eric Sunshine wrote: > On Sun, Dec 13, 2015 at 4:31 AM, Karthik Nayak wrote: >> On Sun, Dec 13, 2015 at 11:10 AM, Eric Sunshine >> wrote: >>> If the intention is to rid that inner loop of much of the expensive >>> processing, then wouldn't we want to introduce a

Re: [PATCH/RFC 00/10] ref-filter: use parsing functions

2015-12-14 Thread Junio C Hamano
Eric Sunshine writes: > On Fri, Dec 11, 2015 at 5:49 PM, Junio C Hamano wrote: >> Karthik Nayak writes: >>> ref-filter: introduce a parsing function for each atom in valid_atom >>> ref-filter: introduce struct used_atom >>> ref-fitler: bump match_atom() name to the top >>> ref-filter: s

Re: [PATCH/RFC 00/10] ref-filter: use parsing functions

2015-12-13 Thread Eric Sunshine
On Sun, Dec 13, 2015 at 4:31 AM, Karthik Nayak wrote: > On Sun, Dec 13, 2015 at 11:10 AM, Eric Sunshine > wrote: >> If the intention is to rid that inner loop of much of the expensive >> processing, then wouldn't we want to introduce an enum of valid atoms >> which is to be a member of 'struct u

Re: [PATCH/RFC 00/10] ref-filter: use parsing functions

2015-12-13 Thread Karthik Nayak
On Sun, Dec 13, 2015 at 11:10 AM, Eric Sunshine wrote: > On Fri, Dec 11, 2015 at 5:49 PM, Junio C Hamano wrote: >> Karthik Nayak writes: >>> ref-filter: introduce a parsing function for each atom in valid_atom >>> ref-filter: introduce struct used_atom >>> ref-fitler: bump match_atom() nam

Re: [PATCH/RFC 00/10] ref-filter: use parsing functions

2015-12-12 Thread Eric Sunshine
On Fri, Dec 11, 2015 at 5:49 PM, Junio C Hamano wrote: > Karthik Nayak writes: >> ref-filter: introduce a parsing function for each atom in valid_atom >> ref-filter: introduce struct used_atom >> ref-fitler: bump match_atom() name to the top >> ref-filter: skip deref specifier in match_at

Re: [PATCH/RFC 00/10] ref-filter: use parsing functions

2015-12-11 Thread Junio C Hamano
Karthik Nayak writes: > Karthik Nayak (10): > ref-filter: introduce a parsing function for each atom in valid_atom > ref-filter: introduce struct used_atom > ref-fitler: bump match_atom() name to the top > ref-filter: skip deref specifier in match_atom_name() > ref-filter: introduce col

Re: [PATCH/RFC 00/10] ref-filter: use parsing functions

2015-11-25 Thread Karthik Nayak
On Wed, Nov 25, 2015 at 3:18 AM, Jeff King wrote: > On Thu, Nov 12, 2015 at 01:14:26AM +0530, Karthik Nayak wrote: > >> Karthik Nayak (10): >> ref-filter: introduce a parsing function for each atom in valid_atom >> ref-filter: introduce struct used_atom >> ref-fitler: bump match_atom() name

Re: [PATCH/RFC 00/10] ref-filter: use parsing functions

2015-11-24 Thread Jeff King
On Thu, Nov 12, 2015 at 01:14:26AM +0530, Karthik Nayak wrote: > Karthik Nayak (10): > ref-filter: introduce a parsing function for each atom in valid_atom > ref-filter: introduce struct used_atom > ref-fitler: bump match_atom() name to the top > ref-filter: skip deref specifier in match_a

[PATCH/RFC 00/10] ref-filter: use parsing functions

2015-11-11 Thread Karthik Nayak
Carried over http://thread.gmane.org/gmane.comp.version-control.git/279226/focus=279352. Where we were talking about pre-parsing most of the atoms so that we do not have to parse them in ref-filter:populate_value(), where we could now instead only fill in necessary values. This series aims to intr