Re: [PATCH/RFC 4/7] refs: factor delete_ref loose ref step into a helper

2013-08-29 Thread Brad King
On 08/29/2013 01:28 PM, Junio C Hamano wrote: > Brad King writes: >> -if (!(flag & REF_ISPACKED) || flag & REF_ISSYMREF) { >> +if (!(type & REF_ISPACKED) || type & REF_ISSYMREF) { > > Hits from "git grep REF_IS" tell me that all users of REF_IS* symbol > that check if a bit is on in a wor

Re: [PATCH/RFC 4/7] refs: factor delete_ref loose ref step into a helper

2013-08-29 Thread Junio C Hamano
Brad King writes: > Factor loose ref deletion into helper function delete_ref_loose to allow > later use elsewhere. While at it, rename local names 'flag => type' and > 'delopt => flags' for consistency with callers and called functions. > > Signed-off-by: Brad King > --- > refs.c | 24 +

[PATCH/RFC 4/7] refs: factor delete_ref loose ref step into a helper

2013-08-29 Thread Brad King
Factor loose ref deletion into helper function delete_ref_loose to allow later use elsewhere. While at it, rename local names 'flag => type' and 'delopt => flags' for consistency with callers and called functions. Signed-off-by: Brad King --- refs.c | 24 1 file chang