Junio C Hamano writes:
> Sent off-list to reduce noise level; this is an issue that attracts
> a lot of useless comments.
Heh, somehow I screwed up and sent on-list X-<.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More m
Matthieu Moy writes:
> Not very important, but two spaces after a period is what one is
> supposed to do in English. Not everybody follow the rule, but it seems
> backward to change the code to break it.
I am old fashioned enough to personally agree, but this practice
that originates in the type
On 05/29/2015 02:11 AM, Matthieu Moy wrote:
The point of separating them is that the rename implies a relatively
long patch (you have 17 occurences of 'refinfo' in the deletion part of
your patch), but it is straightforward to review (apply, run "git diff
--color-words" and press space a few time
Karthik Nayak writes:
> On 05/29/2015 01:56 AM, Matthieu Moy wrote:
>> Karthik Nayak writes:
>>
>>> Rename 'refinfo' to 'ref_array_item' and intoduce 'ref_filter_cbdata'
>>
>> The fact that you need to use "and" to describe your changes is a hint
>> that you can split better.
>>
>
> But the patc
On 05/29/2015 01:56 AM, Matthieu Moy wrote:
Karthik Nayak writes:
Rename 'refinfo' to 'ref_array_item' and intoduce 'ref_filter_cbdata'
The fact that you need to use "and" to describe your changes is a hint
that you can split better.
But the patch alone wouldn't make much sense here, as t
Karthik Nayak writes:
> Rename 'refinfo' to 'ref_array_item' and intoduce 'ref_filter_cbdata'
The fact that you need to use "and" to describe your changes is a hint
that you can split better.
The patch looks much better, but I think you still need to split more to
make it easier to review.
> -
Rename 'refinfo' to 'ref_array_item' and intoduce 'ref_filter_cbdata'
which will hold 'ref_filter' (Conditions to filter the refs on) and
'ref_array' (The array of ref_array_items). Modify the code to use
these new structures.
Re-order the fields in 'ref_array_item' so that refname can be
eventual
7 matches
Mail list logo
