Re: [PATCH][RFC] grep: add color.grep.matchcontext and color.grep.matchselected

2014-10-28 Thread Junio C Hamano
Zoltan Klinger zoltan.klin...@gmail.com writes: I like René's approach, too. It's more flexible, supports the old behaviour and it scratches my itch as well. OK, then let's go with that one. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to

Re: [PATCH][RFC] grep: add color.grep.matchcontext and color.grep.matchselected

2014-10-28 Thread René Scharfe
Am 28.10.2014 um 00:32 schrieb Zoltan Klinger: I like René's approach, too. It's more flexible, supports the old behaviour and it scratches my itch as well. Don't mind if you dropped my patch and used René's instead. Good. :) And here's the t/ part of your patch, slightly changed to exercise

[PATCH][RFC] grep: add color.grep.matchcontext and color.grep.matchselected

2014-10-27 Thread René Scharfe
The config option color.grep.match can be used to specify the highlighting color for matching strings. Add the options matchContext and matchSelected to allow different colors to be specified for matching strings in the context vs. in selected lines. This is similar to the ms and mc specifiers

Re: [PATCH][RFC] grep: add color.grep.matchcontext and color.grep.matchselected

2014-10-27 Thread Junio C Hamano
René Scharfe l@web.de writes: The config option color.grep.match can be used to specify the highlighting color for matching strings. Add the options matchContext and matchSelected to allow different colors to be specified for matching strings in the context vs. in selected lines. This

Re: [PATCH][RFC] grep: add color.grep.matchcontext and color.grep.matchselected

2014-10-27 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: René Scharfe l@web.de writes: The config option color.grep.match can be used to specify the highlighting color for matching strings. Add the options matchContext and matchSelected to allow different colors to be specified for matching strings in

Re: [PATCH][RFC] grep: add color.grep.matchcontext and color.grep.matchselected

2014-10-27 Thread Zoltan Klinger
I like René's approach, too. It's more flexible, supports the old behaviour and it scratches my itch as well. Don't mind if you dropped my patch and used René's instead. Only *very* lightly tested, and a test for t/is missing anyway. Just wanted to quickly show what I meant. You'd set