Re: [PATCH] [GSoC][MICRO] Forbid "log --graph --no-walk"

2015-03-06 Thread Junio C Hamano
Dongcan Jiang writes: > At first, I also tried to only judge the value of "revs->no_walk && > revs->graph", but unfortunately, it failed to pass all cases in > t4052-stat-output.sh. > e.g. command "git show --stat --graph" failed to get the correct result. > > Finally, this is because that "revs-

Re: [PATCH] [GSoC][MICRO] Forbid "log --graph --no-walk"

2015-03-06 Thread Dongcan Jiang
Hi, Eric and René Thanks for your suggestions. Good ideas! > Genuine question: Despite the GSoC micro-project mentioning only > 'log', is it ever meaningful for these two options to be specified > together? I suspect not, but it would be nice to hear from someone > more familiar with the issue. I

Re: [PATCH] [GSoC][MICRO] Forbid "log --graph --no-walk"

2015-03-06 Thread René Scharfe
Am 06.03.2015 um 09:55 schrieb Dongcan Jiang: Because --graph is about connected history while --no-walk is about discrete points. revision.c: Judge whether --graph and --no-walk come together when running git-log. buildin/log.c: Set git-log cmd flag. Documentation/rev-list-options.txt: Add sp

Re: [PATCH] [GSoC][MICRO] Forbid "log --graph --no-walk"

2015-03-06 Thread Eric Sunshine
On Fri, Mar 6, 2015 at 3:55 AM, Dongcan Jiang wrote: > Forbid "log --graph --no-walk Style: drop capitalization in the Subject: line. Also prefix with the command or module being modified, followed by a colon. So: log: forbid combining --graph and --no-walk or: revision: forbid combini

[PATCH] [GSoC][MICRO] Forbid "log --graph --no-walk"

2015-03-06 Thread Dongcan Jiang
Because --graph is about connected history while --no-walk is about discrete points. revision.c: Judge whether --graph and --no-walk come together when running git-log. buildin/log.c: Set git-log cmd flag. Documentation/rev-list-options.txt: Add specification on the forbidden usage. Signed-off-