Re: [PATCH] {fetch,upload}-pack: clearly mark unreachable v2 code

2018-03-30 Thread Stefan Beller
On Fri, Mar 30, 2018 at 12:03 PM, Brandon Williams wrote: > On 03/30, Ævar Arnfjörð Bjarmason wrote: >> Change the switch statement driving upload_pack_v2() and >> do_fetch_pack_v2() to clearly indicate that the FETCH_DONE case is >> being handled implicitly by other code,

Re: [PATCH] {fetch,upload}-pack: clearly mark unreachable v2 code

2018-03-30 Thread Brandon Williams
On 03/30, Ævar Arnfjörð Bjarmason wrote: > Change the switch statement driving upload_pack_v2() and > do_fetch_pack_v2() to clearly indicate that the FETCH_DONE case is > being handled implicitly by other code, instead of giving the reader > the impression that the "continue" statement is needed.

[PATCH] {fetch,upload}-pack: clearly mark unreachable v2 code

2018-03-30 Thread Ævar Arnfjörð Bjarmason
Change the switch statement driving upload_pack_v2() and do_fetch_pack_v2() to clearly indicate that the FETCH_DONE case is being handled implicitly by other code, instead of giving the reader the impression that the "continue" statement is needed. This issue was flagged as DEADCODE by