Re: [PATCH] Add grep.fullName config variable

Andreas Schwab writes: > Junio C Hamano writes: > >> Don't we have the exact same issue for the editor, by the way? >> Shouldn't we be running it in the original subdirectory as well? > > It's called with an absolute name, so it shouldn't care. But we should not have to call with absolute paths

Re: [PATCH] Add grep.fullName config variable

Andreas Schwab writes: > Junio C Hamano writes: > >> Andreas Schwab writes: >> >>> This configuration variable sets the default for the --full-name option. >>> >>> Signed-off-by: Andreas Schwab >>> --- >> >> Would this change break Porcelains (e.g. Emacs modes) and force them >> to be updated

Re: [PATCH] Add grep.fullName config variable

Junio C Hamano writes: > Don't we have the exact same issue for the editor, by the way? > Shouldn't we be running it in the original subdirectory as well? It's called with an absolute name, so it shouldn't care. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7

Re: [PATCH] Add grep.fullName config variable

Andreas Schwab writes: > Yes, that would be required. On the other hand, currently it is > impossible to cut-n-paste a file name without --full-name, since the > pager is always started in top-level. Perhaps it is better to fix the > latter? So far we never cared where the pager runs, but as a

Re: [PATCH] Add grep.fullName config variable

Junio C Hamano writes: > Andreas Schwab writes: > >> This configuration variable sets the default for the --full-name option. >> >> Signed-off-by: Andreas Schwab >> --- > > Would this change break Porcelains (e.g. Emacs modes) and force them > to be updated to explicitly pass --no-full-name to

Re: [PATCH] Add grep.fullName config variable

Andreas Schwab writes: > This configuration variable sets the default for the --full-name option. > > Signed-off-by: Andreas Schwab > --- Would this change break Porcelains (e.g. Emacs modes) and force them to be updated to explicitly pass --no-full-name to unbreak them? > Documentation/git-g

[PATCH] Add grep.fullName config variable

This configuration variable sets the default for the --full-name option. Signed-off-by: Andreas Schwab --- Documentation/git-grep.txt | 3 +++ grep.c | 5 + 2 files changed, 8 insertions(+) diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt index f83733

[PATCH] Add grep.fullName config variable

This configuration variable sets the default for the --full-name option. Signed-off-by: Andreas Schwab --- Documentation/git-grep.txt | 3 +++ grep.c | 5 + 2 files changed, 8 insertions(+) diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt index f83733