Re: [PATCH] Add the tag.gpgsign option to sign all created tags

2016-03-20 Thread Laurent Arnoud
On Sun, Mar 20, 2016 at 12:52:17PM -0400, Jeff King wrote: > That behavior makes more sense to me, but I don't think it's what your > patch does (v1 or v2). Perhaps it would make sense to add some tests, > both to verify that it is behaving as expected, and to protect that > behavior from future ch

Re: [PATCH] Add the tag.gpgsign option to sign all created tags

2016-03-20 Thread Jeff King
On Sun, Mar 20, 2016 at 01:20:23PM +0100, Laurent Arnoud wrote: > Hi Jeff, > > On Sun, Mar 20, 2016 at 12:29:12AM -0400, Jeff King wrote: > > We have commit.gpgsign, so this makes some sense. Would you want to sign > > _all_ tags created with "git tag", including lightweight tags, or only > > tho

Re: [PATCH] Add the tag.gpgsign option to sign all created tags

2016-03-20 Thread Laurent Arnoud
Hi Jeff, On Sun, Mar 20, 2016 at 12:29:12AM -0400, Jeff King wrote: > We have commit.gpgsign, so this makes some sense. Would you want to sign > _all_ tags created with "git tag", including lightweight tags, or only > those that would already create a tag object (i.e., annotated tags)? Yes those

Re: [PATCH] Add the tag.gpgsign option to sign all created tags

2016-03-19 Thread Jeff King
On Sat, Mar 19, 2016 at 07:23:10PM +0100, Laurent Arnoud wrote: > The tag.gpgsign config option allows to sign all > commits automatically. We have commit.gpgsign, so this makes some sense. Would you want to sign _all_ tags created with "git tag", including lightweight tags, or only those that wo

[PATCH] Add the tag.gpgsign option to sign all created tags

2016-03-19 Thread Laurent Arnoud
The tag.gpgsign config option allows to sign all commits automatically. Signed-off-by: Laurent Arnoud --- Documentation/config.txt | 3 +++ builtin/tag.c| 19 --- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/Documentation/config.txt b/Documentation