On Sat, Oct 27, 2018 at 04:12:40PM +0900, Junio C Hamano wrote:
> > Yeah, I agree that would be fine, too. I think there are two dimensions
> > in which to look at the problem, like so:
> >
> > rev-list rev-parse
> > -
> > --globclearsclears
> > --all
Jeff King writes:
>> I actually was hoping to see a test that contrasts "--all" (which
>> lacks the alleged "clear exclude" bug) with another option that does
>> have the "clear exclude", both used with rev-parse, i.e.
>>
>> $ git rev-parse --exclude='*' --glob='*' --glob='*'
>> ... all
On Fri, Oct 26, 2018 at 08:43:37AM +0900, Junio C Hamano wrote:
> Jeff King writes:
>
> > An easy test is:
> >
> > $ git rev-list --no-walk --exclude='*' --all --all
> > 3289ca716320457af5d2dd550b716282ad22da11
> > ...a bunch of other tip commits...
> >
> > $ git rev-parse --exclude='*'
Jeff King writes:
> An easy test is:
>
> $ git rev-list --no-walk --exclude='*' --all --all
> 3289ca716320457af5d2dd550b716282ad22da11
> ...a bunch of other tip commits...
>
> $ git rev-parse --exclude='*' --all --all
> [no output, but it should print those same tip commits]
I
On Wed, Oct 24, 2018 at 11:49:06AM +0200, Andreas Gruenbacher wrote:
> > That is why I asked what "problem" this patch fixes. Without
> > answering that question, it is unclear if the patch is completing
> > missing coverage for "--all", or it is cargo culting an useless
> > clearing done for
On Wed, 24 Oct 2018 at 11:24, Junio C Hamano wrote:
> Andreas Gruenbacher writes:
> >> All other glob options do show_reference with for_each_ref_in() and
> >> then calls clear_ref_exclusion(), and logically the patch makes
> >> sense.
> >>
> >> What is the "problem" this patch fixes, though?
Andreas Gruenbacher writes:
>> All other glob options do show_reference with for_each_ref_in() and
>> then calls clear_ref_exclusion(), and logically the patch makes
>> sense.
>>
>> What is the "problem" this patch fixes, though? Is it easy to add a
>> new test to t/6018-rev-list-glob.sh to
On Wed, 24 Oct 2018 at 06:35, Junio C Hamano wrote:
> Andreas Gruenbacher writes:
>
> > Commit [1] added the --exclude option to revision.c. The --all,
> > --branches, --tags, --remotes, and --glob options clear the exclude
> > list. Shortly therafter, commit [2] added the same to 'git
Andreas Gruenbacher writes:
> Commit [1] added the --exclude option to revision.c. The --all,
> --branches, --tags, --remotes, and --glob options clear the exclude
> list. Shortly therafter, commit [2] added the same to 'git rev-parse',
> but without clearing the exclude list for the --all
Commit [1] added the --exclude option to revision.c. The --all,
--branches, --tags, --remotes, and --glob options clear the exclude
list. Shortly therafter, commit [2] added the same to 'git rev-parse',
but without clearing the exclude list for the --all option. Fix that.
[1] e7b432c52
10 matches
Mail list logo