Re: [PATCH] CodingGuidelines: clarify multi-line brace style

2017-01-17 Thread Junio C Hamano
choice is yours in your new code, but do not churn existing code for "gray" guidelines. If we made _that_ clear as a rule we dictate, hopefully we'd have less chance to see "a bunch of patches that do nothing but change brace style", I would think. > -- >8 -- >

Re: [PATCH] CodingGuidelines: clarify multi-line brace style

2017-01-17 Thread Jeff King
expected to match the overall style of existing code. Modifications to existing code is expected to match the style the surrounding code already uses (even if it doesn't match the overall style of existing code). But if you must have a list of rules, here they are. I guess

Re: [PATCH] CodingGuidelines: clarify multi-line brace style

2017-01-17 Thread Junio C Hamano
them, as long as you are consistent with surrounding code. Do not change style of existing code only to flip among these styles, though. That obviously is not limited to the rule/guideline for braces. > -- >8 -- > Subject: [PATCH] CodingGuidelines: clarify multi-line br

[PATCH] CodingGuidelines: clarify multi-line brace style

2017-01-16 Thread Jeff King
r > that you're supposed to use judgement about readability. So here's a patch. I know we've usually tried to keep this file to guidelines and not rules, but clearly it has not been clear-cut enough in this instance. -- >8 -- Subject: [PATCH] CodingGuidelines: clarify m