Original Message
Subject:[PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit()
Date: Fri, 21 Mar 2014 07:24:46 +0530
From: Ashwin Jha ajha@gmail.com
To: git@vger.kernel.org
CC: Ashwin Jha ajha@gmail.com
modified fsck.c:fsck_commit(). Replaced
On Fri, Mar 21, 2014 at 5:18 AM, Ashwin Jha ajha@gmail.com wrote:
On Fri, Mar 21, 2014 at 9:03 AM, Eric Sunshine sunsh...@sunshineco.com
wrote:
On Thu, Mar 20, 2014 at 9:54 PM, Ashwin Jha ajha@gmail.com wrote:
Subject: [PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit
Miniproject 15. Rewrite fsck.c:fsck_commit()
starts_with() seems much more relevant than memcmp(). It uses one less
argument and its return value makes more sense.
As a justification, uses one less argument falls flat, and really
has nothing to do with the decision to make the change. The bit about
modified fsck.c:fsck_commit(). Replaced memcmp() with starts_with() function.
starts_with() seems much more relevant than memcmp(). It uses one less argument
and its return value makes more sense.
skip_prefix() is not used as it uses strcmp() internally which seems
unnecessarily
for current task.
Thanks for the submission. Comments below to give you a feel for the
Git review process...
On Thu, Mar 20, 2014 at 9:54 PM, Ashwin Jha ajha@gmail.com wrote:
Subject: [PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit()
The subject becomes part of the permanent Git history, but the fact
5 matches
Mail list logo