Re: [PATCH] Makefile: add pending semantic patches

2018-11-13 Thread Junio C Hamano
SZEDER Gábor writes: >> > inifinite recursion)? Or are they "correct but not immediately >> > necessary" (e.g. because calling read_cache() does not hurt until >> > that function gets removed, so rewriting the callers to call >> > read_index() with &the_index may be correct but not immediately >

Re: [PATCH] Makefile: add pending semantic patches

2018-11-13 Thread SZEDER Gábor
On Fri, Nov 09, 2018 at 01:58:01PM -0800, Stefan Beller wrote: > On Thu, Nov 8, 2018 at 9:18 PM Junio C Hamano wrote: > > Are they wrong changes (e.g. a carelessly written read_cache() to > > read_index(&the_index) conversion may munge the implementation of > > read_cache(...) { return read_index(

Re: [PATCH] Makefile: add pending semantic patches

2018-11-09 Thread Stefan Beller
On Thu, Nov 8, 2018 at 9:18 PM Junio C Hamano wrote: > > Stefan Beller writes: > > > From: SZEDER Gábor > > > > Add a description and place on how to use coccinelle for large refactorings > > that happen only once. > > > > Based-on-work-by: SZEDER Gábor > > Signed-off-by: Stefan Beller > > ---

Re: [PATCH] Makefile: add pending semantic patches

2018-11-09 Thread Stefan Beller
On Thu, Nov 8, 2018 at 8:56 PM Martin Ågren wrote: > I haven't followed the original discussion too carefully, so I'll read > this like someone new to the topic probably would. Thanks! > A nit, perhaps, but I was genuinely confused at first. The subject is > "Makefile: add pending semantic patch

Re: [PATCH] Makefile: add pending semantic patches

2018-11-08 Thread Junio C Hamano
Stefan Beller writes: > From: SZEDER Gábor > > Add a description and place on how to use coccinelle for large refactorings > that happen only once. > > Based-on-work-by: SZEDER Gábor > Signed-off-by: Stefan Beller > --- > > I consider including this patch in a resend instead. > It outlays the

Re: [PATCH] Makefile: add pending semantic patches

2018-11-08 Thread Martin Ågren
On Thu, 8 Nov 2018 at 21:53, Stefan Beller wrote: > > From: SZEDER Gábor > I haven't followed the original discussion too carefully, so I'll read this like someone new to the topic probably would. A nit, perhaps, but I was genuinely confused at first. The subject is "Makefile: add pending seman

[PATCH] Makefile: add pending semantic patches

2018-11-08 Thread Stefan Beller
From: SZEDER Gábor Add a description and place on how to use coccinelle for large refactorings that happen only once. Based-on-work-by: SZEDER Gábor Signed-off-by: Stefan Beller --- I consider including this patch in a resend instead. It outlays the basics of such a new workflow, which we can