Re: [PATCH] Makefile: tweak sed invocation

2018-07-02 Thread Alejandro R . Sedeño
On 2018-06-26 14:35, Junio C Hamano wrote: Having said that, I'm a bit surprised that our build infrastructure and shell scripts still work on tools on SunOS. I used to have access to SunOS/Solaris boxes and tried to be careful not to break them unnecessarily, but these days I don't, so I

Re: [PATCH] Makefile: tweak sed invocation

2018-06-25 Thread Alejandro R . Sedeño
On 2018-06-25 16:15, Eric Sunshine wrote: On Mon, Jun 25, 2018 at 3:18 PM Alejandro R. Sedeño wrote: With GNU sed, the r command doesn't care if a space separates it and the filename it reads from. With SunOS sed, the space is required. MacOS and the various BSD's ship with BSD 'sed', not

Re: [PATCH] Makefile: tweak sed invocation

2018-06-25 Thread Eric Sunshine
On Mon, Jun 25, 2018 at 3:18 PM Alejandro R. Sedeño wrote: > With GNU sed, the r command doesn't care if a space separates it and > the filename it reads from. > > With SunOS sed, the space is required. MacOS and the various BSD's ship with BSD 'sed', not GNU 'sed', so it seemed prudent to check

[PATCH] Makefile: tweak sed invocation

2018-06-25 Thread Alejandro R . Sedeño
With GNU sed, the r command doesn't care if a space separates it and the filename it reads from. With SunOS sed, the space is required. Signed-off-by: Alejandro R. Sedeño --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index e4b503d..5bac181