Re: [PATCH] Provide a dirname() function when NO_LIBGEN_H=YesPlease

2015-09-30 Thread Junio C Hamano
Johannes Schindelin writes: > I stumbled over the compile warning when upgrading Git for Windows > to 2.6.0. There was a left-over NO_LIBGEN_H=YesPlease (which we > no longer need in Git for Windows 2.x), but it did point to the > fact that we

Re: [PATCH] Provide a dirname() function when NO_LIBGEN_H=YesPlease

2015-09-30 Thread Ramsay Jones
Hi Johannes, On 30/09/15 15:50, Johannes Schindelin wrote: > When there is no `libgen.h` to our disposal, we miss the `dirname()` > function. > > So far, we only had one user of that function: credential-cache--daemon > (which was only compiled when Unix sockets are available, anyway). But > now

[PATCH] Provide a dirname() function when NO_LIBGEN_H=YesPlease

2015-09-30 Thread Johannes Schindelin
When there is no `libgen.h` to our disposal, we miss the `dirname()` function. So far, we only had one user of that function: credential-cache--daemon (which was only compiled when Unix sockets are available, anyway). But now we also have `builtin/am.c` as user, so we need it. Since `dirname()`