Re: [PATCH] Reduce performance penalty for turned off traces

On Wed, Nov 15, 2017 at 11:14:20AM -0800, Stefan Beller wrote: > > I did manually disable HAVE_VARIADIC_MACROS and confirmed that the > > result builds and passes the test suite (though I suspect that GIT_TRACE > > is not well exercised by the suite). > > GIT_TRACE is exercised in the test suite

Re: [PATCH] Reduce performance penalty for turned off traces

On Sun, Nov 12, 2017 at 11:24:11PM +, Gennady Kupava wrote: > In reality, gcc didn't do that and I saw 3 function calls. I am pretty > sure that compiler of the distant bright future will do that, and only > problem would be to eliminate that single function call. Hopefully > with -flto it

Re: [PATCH] Reduce performance penalty for turned off traces

On Sun, Nov 12, 2017 at 6:17 AM, Jeff King wrote: > On Sat, Nov 11, 2017 at 07:28:58PM +, gennady.kup...@gmail.com wrote: > >> From: Gennady Kupava >> >> Signed-off-by: Gennady Kupava > > Thanks, and welcome to the list. Welcome

Re: [PATCH] Reduce performance penalty for turned off traces

Hi Jeff, thanks for such detailed review and additional testing. Below are just some discussion related review comments, Please expect patch itself on some evening during coming week. On 12 November 2017 at 14:17, Jeff King wrote: > > On Sat, Nov 11, 2017 at 07:28:58PM +,

Re: [PATCH] Reduce performance penalty for turned off traces

On Sat, Nov 11, 2017 at 07:28:58PM +, gennady.kup...@gmail.com wrote: > From: Gennady Kupava > > Signed-off-by: Gennady Kupava Thanks, and welcome to the list. > --- > One of the tasks siggested in scope of 'Git sprint weekend'. > Couple of

[PATCH] Reduce performance penalty for turned off traces

From: Gennady Kupava Signed-off-by: Gennady Kupava --- One of the tasks siggested in scope of 'Git sprint weekend'. Couple of chioces made here: 1. Use constant instead of NULL to indicate default trace level, this just makes everything simpler.