Re: [PATCH] Remove the line length limit for graft files

2013-12-27 Thread Junio C Hamano
Jonathan Nieder writes: > Johannes Schindelin wrote: >> On Fri, 27 Dec 2013, Jonathan Nieder wrote: > >>> Is this easy to reproduce so some interested but lazy person could >>> write a test? >> >> Yep. Make 25 orphan commits, add a graft line to make the first a merge of >> the rest. > > Thanks.

Re: [PATCH] Remove the line length limit for graft files

2013-12-27 Thread Johannes Schindelin
Hi Jonathan, On Fri, 27 Dec 2013, Jonathan Nieder wrote: > Johannes Schindelin wrote: > > On Fri, 27 Dec 2013, Jonathan Nieder wrote: > > >> Is this easy to reproduce so some interested but lazy person could > >> write a test? > > > > Yep. Make 25 orphan commits, add a graft line to make the fir

Re: [PATCH] Remove the line length limit for graft files

2013-12-27 Thread Johannes Schindelin
Hi Jonathan, On Fri, 27 Dec 2013, Jonathan Nieder wrote: > Johannes Schindelin wrote: > > > it returns EOF only if ch == EOF *and* sb->len == 0, i.e. if no characters > > have been read before hitting EOF. > > Yep. api-strbuf.txt even says so. I never bothered to look ;-) > Sorry for the non

Re: [PATCH] Remove the line length limit for graft files

2013-12-27 Thread Jonathan Nieder
Johannes Schindelin wrote: > On Fri, 27 Dec 2013, Jonathan Nieder wrote: >> Is this easy to reproduce so some interested but lazy person could >> write a test? > > Yep. Make 25 orphan commits, add a graft line to make the first a merge of > the rest. Thanks. Here's a pair of tests doing that. S

Re: [PATCH] Remove the line length limit for graft files

2013-12-27 Thread Jonathan Nieder
Johannes Schindelin wrote: > it returns EOF only if ch == EOF *and* sb->len == 0, i.e. if no characters > have been read before hitting EOF. Yep. api-strbuf.txt even says so. Sorry for the nonsense. For what it's worth, Reviewed-by: Jonathan Nieder -- To unsubscribe from this list: send the l

Re: [PATCH] Remove the line length limit for graft files

2013-12-27 Thread Junio C Hamano
Johannes Schindelin writes: > Support for grafts predates Git's strbuf, and hence it is understandable > that there was a hard-coded line length limit of 1023 characters (which > was chosen a bit awkwardly, given that it is *exactly* one byte short of > aligning with the 41 bytes occupied by a co

Re: [PATCH] Remove the line length limit for graft files

2013-12-27 Thread Johannes Schindelin
Hi, On Fri, 27 Dec 2013, Jonathan Nieder wrote: > Johannes Schindelin wrote: > > [...] > > --- > > builtin/blame.c | 8 > > commit.c| 10 +- > > 2 files changed, 9 insertions(+), 9 deletions(-) > > Is this easy to reproduce so some interested but lazy person could > w

Re: [PATCH] Remove the line length limit for graft files

2013-12-27 Thread Jonathan Nieder
Hi, Johannes Schindelin wrote: > While regular commit histories hardly win comprehensibility in general > if they merge more than twenty-two branches in one go, it is not Git's > business to limit grafts in such a way. Fun. :) Makes sense. [...] > --- > builtin/blame.c | 8 > commit

[PATCH] Remove the line length limit for graft files

2013-12-27 Thread Johannes Schindelin
Support for grafts predates Git's strbuf, and hence it is understandable that there was a hard-coded line length limit of 1023 characters (which was chosen a bit awkwardly, given that it is *exactly* one byte short of aligning with the 41 bytes occupied by a commit name and the following space or