RE: [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509

2018-01-11 Thread Randall S. Becker
On January 11, 2018 1:31 AM Jeff King wrote" > On Thu, Jan 11, 2018 at 12:40:05AM -0500, Randall S. Becker wrote: > > diff --git a/transport-helper.c b/transport-helper.c index > > 3640804..68a4e30 100644 > > --- a/transport-helper.c > > +++ b/transport-helper.c > > @@ -1202,7 +1202,7 @@ static

RE: [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509

2018-01-11 Thread Randall S. Becker
On January 11, 2018 1:21 AM , Jeff King wrote: > On Thu, Jan 11, 2018 at 12:40:05AM -0500, Randall S. Becker wrote: > > This fix was needed on HPE NonStop NSE where SSIZE_MAX is less than > > BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c > > was the only place outside of

Re: [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509

2018-01-10 Thread Jeff King
On Thu, Jan 11, 2018 at 12:40:05AM -0500, Randall S. Becker wrote: > diff --git a/transport-helper.c b/transport-helper.c > index 3640804..68a4e30 100644 > --- a/transport-helper.c > +++ b/transport-helper.c > @@ -1202,7 +1202,7 @@ static int udt_do_read(struct unidirectional_transfer > *t) >

Re: [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509

2018-01-10 Thread Jeff King
On Thu, Jan 11, 2018 at 12:40:05AM -0500, Randall S. Becker wrote: > This fix was needed on HPE NonStop NSE where SSIZE_MAX is less than > BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c > was the only place outside of wrapper.c. For my own curiosity, what is SSIZE_MAX on

RE: [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509

2018-01-10 Thread Randall S. Becker
On January 11, 2018 12:40 AM, I wrote: > Subject: [PATCH] Replaced read with xread in transport-helper.c to fix > SSIZE_MAX overun in t5509 > > This fix was needed on HPE NonStop NSE where SSIZE_MAX is less than > BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c > was the

[PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509

2018-01-10 Thread Randall S. Becker
This fix was needed on HPE NonStop NSE where SSIZE_MAX is less than BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c was the only place outside of wrapper.c. Signed-off-by: Randall S. Becker --- transport-helper.c | 2 +- 1 file changed, 1