Re: [PATCH] Restore umasks influence on the permissions of work tree created by clone

2012-07-09 Thread Alex Riesen
On Mon, Jul 9, 2012 at 3:41 AM, Junio C Hamano gits...@pobox.com wrote: Alex Riesen raa.l...@gmail.com writes: The original (shell coded) version of the git-clone just used mkdir(1) to create the working directories. The builtin changed the mode argument to mkdir(2) to 0755, which was a bit

Re: [PATCH] Restore umasks influence on the permissions of work tree created by clone

2012-07-09 Thread Jeff King
On Sun, Jul 08, 2012 at 06:41:39PM -0700, Junio C Hamano wrote: Alex Riesen raa.l...@gmail.com writes: The original (shell coded) version of the git-clone just used mkdir(1) to create the working directories. The builtin changed the mode argument to mkdir(2) to 0755, which was a bit

Re: [PATCH] Restore umasks influence on the permissions of work tree created by clone

2012-07-09 Thread Junio C Hamano
Jeff King p...@peff.net writes: Does the mkdir of rr-cache/* in rerere.c make the same mistake? The rr-cache root is made with 0777, and the files inside each subdirectory are created with 0666. So it is the only thing preventing users of shared repos from using rerere. Quite possibly yes.

Re: [PATCH] Restore umasks influence on the permissions of work tree created by clone

2012-07-09 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Jeff King p...@peff.net writes: Does the mkdir of rr-cache/* in rerere.c make the same mistake? The rr-cache root is made with 0777, and the files inside each subdirectory are created with 0666. So it is the only thing preventing users of shared

Re: [PATCH] Restore umasks influence on the permissions of work tree created by clone

2012-07-08 Thread Junio C Hamano
Alex Riesen raa.l...@gmail.com writes: The original (shell coded) version of the git-clone just used mkdir(1) to create the working directories. The builtin changed the mode argument to mkdir(2) to 0755, which was a bit unfortunate, as there are use A much more important reason why this is a

[PATCH] Restore umasks influence on the permissions of work tree created by clone

2012-07-07 Thread Alex Riesen
The original (shell coded) version of the git-clone just used mkdir(1) to create the working directories. The builtin changed the mode argument to mkdir(2) to 0755, which was a bit unfortunate, as there are use cases where umask-controlled creation is preferred and in any case it is a well-known