Re: [PATCH] add -p: coalesce hunks before testing applicability

2019-06-04 Thread Johannes Schindelin
Hi Phillip, On Mon, 3 Jun 2019, Phillip Wood wrote: > On 03/06/2019 14:40, Johannes Schindelin wrote: > > > > On Sun, 2 Jun 2019, Phillip Wood wrote: > > > > > On 22/03/2019 14:06, Johannes Schindelin wrote: > > > > > > > On Thu, 13 Sep 2018, Phillip Wood wrote: > > > > > > > > > On 03/09/2018 20

Re: [PATCH] add -p: coalesce hunks before testing applicability

2019-06-03 Thread Phillip Wood
Hi On 03/06/2019 14:40, Johannes Schindelin wrote: Hi Phillip, On Sun, 2 Jun 2019, Phillip Wood wrote: On 22/03/2019 14:06, Johannes Schindelin wrote: On Thu, 13 Sep 2018, Phillip Wood wrote: On 03/09/2018 20:01, Jochen Sprickerhof wrote: * Phillip Wood [2018-08-30 14:47]: We could r

Re: [PATCH] add -p: coalesce hunks before testing applicability

2019-06-03 Thread Johannes Schindelin
Hi Phillip, On Sun, 2 Jun 2019, Phillip Wood wrote: > On 22/03/2019 14:06, Johannes Schindelin wrote: > > > On Thu, 13 Sep 2018, Phillip Wood wrote: > > > > > On 03/09/2018 20:01, Jochen Sprickerhof wrote: > > > > > > > * Phillip Wood [2018-08-30 14:47]: > > > > > > > > > We could restore the ol

Re: [PATCH] add -p: coalesce hunks before testing applicability

2019-06-02 Thread Phillip Wood
Hi Dscho Sorry it's taken me so long to get round to replying to this On 22/03/2019 14:06, Johannes Schindelin wrote: Hi, On Thu, 13 Sep 2018, Phillip Wood wrote: On 03/09/2018 20:01, Jochen Sprickerhof wrote: * Phillip Wood [2018-08-30 14:47]: When $newhunk is created it is marked as d

Re: [PATCH] add -p: coalesce hunks before testing applicability

2019-03-22 Thread Johannes Schindelin
Hi, On Thu, 13 Sep 2018, Phillip Wood wrote: > On 03/09/2018 20:01, Jochen Sprickerhof wrote: > > > * Phillip Wood [2018-08-30 14:47]: > >> When $newhunk is created it is marked as dirty to prevent > >> coalesce_overlapping_hunks() from coalescing it. This patch does not > >> change that. What i

Re: [PATCH] add -p: coalesce hunks before testing applicability

2018-09-23 Thread Jochen Sprickerhof
* Phillip Wood [2018-09-13 11:20]: Yes in the long term we want to be able to coalesce edited hunks, but I think it is confusing to call coalesce_overlapping_hunks() at the moment as it will not coalesce the edited hunks. I would see it as a first step into that direction. I think that if yo

Re: [PATCH] add -p: coalesce hunks before testing applicability

2018-09-13 Thread Phillip Wood
Hi Jochen On 03/09/2018 20:01, Jochen Sprickerhof wrote: > Hi Phillip, > > * Phillip Wood [2018-08-30 14:47]: >> When $newhunk is created it is marked as dirty to prevent >> coalesce_overlapping_hunks() from coalescing it. This patch does not >> change that. What is happening is that by calling

Re: [PATCH] add -p: coalesce hunks before testing applicability

2018-09-03 Thread Jochen Sprickerhof
Hi Phillip, * Phillip Wood [2018-08-30 14:47]: When $newhunk is created it is marked as dirty to prevent coalesce_overlapping_hunks() from coalescing it. This patch does not change that. What is happening is that by calling coalesce_overlapping_hunks() the hunks that are not currently selecte

Re: [PATCH] add -p: coalesce hunks before testing applicability

2018-08-30 Thread Junio C Hamano
Phillip Wood writes: > When $newhunk is created it is marked as dirty to prevent > coalesce_overlapping_hunks() from coalescing it. This patch does not > change that. What is happening is that by calling > coalesce_overlapping_hunks() the hunks that are not currently selected > are filtered out a

Re: [PATCH] add -p: coalesce hunks before testing applicability

2018-08-30 Thread Phillip Wood
Dear Jochen/Junio On 28/08/18 19:07, Junio C Hamano wrote: Jochen Sprickerhof writes: When a hunk was split before being edited manually, it does not apply anymore cleanly. Apply coalesce_overlapping_hunks() first to make it work. Enable test for it as well. Signed-off-by: Jochen Sprickerhof

Re: [PATCH] add -p: coalesce hunks before testing applicability

2018-08-28 Thread Junio C Hamano
Jochen Sprickerhof writes: > When a hunk was split before being edited manually, it does not apply > anymore cleanly. Apply coalesce_overlapping_hunks() first to make it > work. Enable test for it as well. > > Signed-off-by: Jochen Sprickerhof > --- > git-add--interactive.perl | 8 >

[PATCH] add -p: coalesce hunks before testing applicability

2018-08-28 Thread Jochen Sprickerhof
When a hunk was split before being edited manually, it does not apply anymore cleanly. Apply coalesce_overlapping_hunks() first to make it work. Enable test for it as well. Signed-off-by: Jochen Sprickerhof --- git-add--interactive.perl | 8 t/t3701-add-interactive.sh | 2 +- 2 files c