Re: [PATCH] allow hooks to ignore their standard input stream

2015-11-16 Thread Clemens Buchacher
Hi Junio, I believe we have finalized the discussion on this patch. Please apply On Fri, Nov 13, 2015 at 06:23:20PM -0500, Jeff King wrote: > > > +test_expect_success 'filling pipe buffer does not cause failure' ' > > + git push parent1 "refs/heads/b/*:refs/heads/b/*" && > > + test_cmp

Re: [PATCH] allow hooks to ignore their standard input stream

2015-11-13 Thread Clemens Buchacher
On Fri, Nov 13, 2015 at 01:17:29AM -0500, Jeff King wrote: > > The test below reliably fails without your patch and passes with it, and > seems to run reasonably quickly for me: Thank you. I confirm the same behavior on my system. Below I have added your change to the patch. -->o-- Since

Re: [PATCH] allow hooks to ignore their standard input stream

2015-11-13 Thread Jeff King
On Fri, Nov 13, 2015 at 10:33:03AM +0100, Clemens Buchacher wrote: > Since ec7dbd145 (receive-pack: allow hooks to ignore its standard input > stream) > the pre-receive and post-receive hooks ignore SIGPIPE. Do the same for the > remaining hooks pre-push and post-rewrite, which read from

Re: [PATCH] allow hooks to ignore their standard input stream

2015-11-12 Thread Jeff King
On Wed, Nov 11, 2015 at 03:42:22PM +0100, Clemens Buchacher wrote: > On Wed, Nov 11, 2015 at 03:39:20PM +0100, Clemens Buchacher wrote: > > + if (write_in_full(proc.in, buf.buf, buf.len) < 0) { > > + /* We do not mind if a hook does not read all refs. */ > > +

Re: [PATCH] allow hooks to ignore their standard input stream

2015-11-12 Thread Jeff King
On Wed, Nov 11, 2015 at 03:39:20PM +0100, Clemens Buchacher wrote: > Since ec7dbd145 (receive-pack: allow hooks to ignore its standard input > stream) the pre-receive and post-receive hooks ignore SIGPIPE. Do the > same for the remaining hooks pre-push and post-rewrite, which read from > standard

Re: [PATCH] allow hooks to ignore their standard input stream

2015-11-11 Thread Clemens Buchacher
On Wed, Nov 11, 2015 at 03:39:20PM +0100, Clemens Buchacher wrote: > + if (write_in_full(proc.in, buf.buf, buf.len) < 0) { > + /* We do not mind if a hook does not read all refs. */ > + if (errno != EPIPE) > + ret =

[PATCH] allow hooks to ignore their standard input stream

2015-11-11 Thread Clemens Buchacher
Since ec7dbd145 (receive-pack: allow hooks to ignore its standard input stream) the pre-receive and post-receive hooks ignore SIGPIPE. Do the same for the remaining hooks pre-push and post-rewrite, which read from standard input. The same arguments for ignoring SIGPIPE apply. Signed-off-by: