Re: [PATCH] am: invoke perl's strftime in C locale

2013-01-15 Thread Jeff King
On Tue, Jan 15, 2013 at 12:59:33AM +0400, Dmitry V. Levin wrote: diff --git a/git-am.sh b/git-am.sh index c682d34..64b88e4 100755 --- a/git-am.sh +++ b/git-am.sh @@ -334,7 +334,7 @@ split_patches () { # Since we cannot guarantee that the commit message is in

Re: [PATCH] am: invoke perl's strftime in C locale

2013-01-15 Thread Antoine Pelisse
This puts all of perl into the C locale, which would mean error messages from perl would be in English rather than the user's language. It probably isn't a big deal, because that snippet of perl is short and not likely to produce problems, but I wonder how hard it would be to set the locale

Re: [PATCH] am: invoke perl's strftime in C locale

2013-01-15 Thread Dmitry V. Levin
On Tue, Jan 15, 2013 at 08:50:59AM -0800, Jeff King wrote: On Tue, Jan 15, 2013 at 05:42:12PM +0100, Antoine Pelisse wrote: This puts all of perl into the C locale, which would mean error messages from perl would be in English rather than the user's language. It probably isn't a big

Re: [PATCH] am: invoke perl's strftime in C locale

2013-01-15 Thread Junio C Hamano
Dmitry V. Levin l...@altlinux.org writes: On Tue, Jan 15, 2013 at 08:50:59AM -0800, Jeff King wrote: On Tue, Jan 15, 2013 at 05:42:12PM +0100, Antoine Pelisse wrote: This puts all of perl into the C locale, which would mean error messages from perl would be in English rather than the

Re: [PATCH] am: invoke perl's strftime in C locale

2013-01-14 Thread Junio C Hamano
Dmitry V. Levin l...@altlinux.org writes: This fixes hg patch format support for locales other than C and en_*, see https://bugzilla.altlinux.org/show_bug.cgi?id=28248 Signed-off-by: Dmitry V. Levin l...@altlinux.org --- Thanks. The reference URL is not very friendly, and you should be