Re: [PATCH] apply: do not allow reversing a 'copy' patch

2015-02-06 Thread Stefan Beller
On Fri, Feb 6, 2015 at 3:06 PM, Junio C Hamano wrote: > Junio C Hamano writes: > + die(_("sorry, cannot apply a 'copying' patch in > reverse (yet)")); Is it wise to give the reader of the output hope that this is not implemented (yet) but may be in the future? I'd drop th

[PATCH] apply: do not allow reversing a 'copy' patch

2015-02-06 Thread Junio C Hamano
Junio C Hamano writes: > Action item: warn users against using "apply -R" on a > patchset with such a patch while this is fixed. This needs to be replaced with the logic to properly reverse a patch that creates a new file by copying from somewhere else, but for now, this would be