Re: [PATCH] attr: convert to new threadsafe API

2016-10-28 Thread Johannes Sixt
Am 28.10.2016 um 00:15 schrieb Stefan Beller: * use attr_start on Windows to dynamically initialize the Single Big Attr Mutex I'm sorry, I didn't find time to test the patch on Windows. I won't be back at my Windows box before Wednesday. -- Hannes

Re: [PATCH] attr: convert to new threadsafe API

2016-10-28 Thread Junio C Hamano
Junio C Hamano writes: >> +if (check) >> +return; /* already done */ >> check = git_attr_check_alloc(); >> while (*argv) { >> struct git_attr *attr = git_attr(*argv); >> git_attr_check_append(check, attr); I thought you made

Re: [PATCH] attr: convert to new threadsafe API

2016-10-28 Thread Junio C Hamano
Stefan Beller writes: > +* Prepare a `struct git_attr_check` using `git_attr_check_initl()` >function, enumerating the names of attributes whose values you are >interested in, terminated with a NULL pointer. Alternatively, an > - empty `struct git_attr_check` can be

Re: [PATCH] attr: convert to new threadsafe API

2016-10-28 Thread Johannes Schindelin
Hi Stefan, On Thu, 27 Oct 2016, Stefan Beller wrote: > * use attr_start on Windows to dynamically initialize the Single Big Attr > Mutex I would have preferred that call in common-main.c, but whatevs... Thanks you for fixing the bug, Dscho

[PATCH] attr: convert to new threadsafe API

2016-10-27 Thread Stefan Beller
This revamps the API of the attr subsystem to be thread safe. Before we had the question and its results in one struct type. The typical usage of the API was static struct git_attr_check *check; if (!check) check = git_attr_check_initl("text", NULL); git_check_attr(path,