[PATCH] blame: add correct paddings in time_buf for align

2014-04-18 Thread Jiang Xin
When show blame information with relative time, the UTF-8 characters in `time_str` will break the alignment of columns after the date field. This is because the `time_buf` padding with spaces should have a constant display width, not a fixed strlen size. So we should call utf8_strwidth() instead

Re: [PATCH] blame: add correct paddings in time_buf for align

2014-04-18 Thread Duy Nguyen
On Fri, Apr 18, 2014 at 3:44 PM, Jiang Xin worldhello@gmail.com wrote: When show blame information with relative time, the UTF-8 characters in `time_str` will break the alignment of columns after the date field. This is because the `time_buf` padding with spaces should have a constant

Re: [PATCH] blame: add correct paddings in time_buf for align

2014-04-18 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Fri, Apr 18, 2014 at 3:44 PM, Jiang Xin worldhello@gmail.com wrote: When show blame information with relative time, the UTF-8 characters in `time_str` will break the alignment of columns after the date field. This is because the `time_buf` padding

Re: [PATCH] blame: add correct paddings in time_buf for align

2014-04-18 Thread Duy Nguyen
On Sat, Apr 19, 2014 at 12:08 AM, Junio C Hamano gits...@pobox.com wrote: Duy Nguyen pclo...@gmail.com writes: On Fri, Apr 18, 2014 at 3:44 PM, Jiang Xin worldhello@gmail.com wrote: When show blame information with relative time, the UTF-8 characters in `time_str` will break the alignment