Re: [PATCH] builtin/describe: introduce --broken flag

2017-03-21 Thread Stefan Beller
On Tue, Mar 21, 2017 at 3:41 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> AFAICT, someone is (was?) using a version of Git that doesn't contain >> f8eaa0ba98 (submodule--helper, module_clone: always operate >> on absolute paths, 2016-03-31). So then the submodule paths were >> made abso

Re: [PATCH] builtin/describe: introduce --broken flag

2017-03-21 Thread Junio C Hamano
Stefan Beller writes: > AFAICT, someone is (was?) using a version of Git that doesn't contain > f8eaa0ba98 (submodule--helper, module_clone: always operate > on absolute paths, 2016-03-31). So then the submodule paths were > made absolute paths on creation of the Gerrit repo. > > And then someone

Re: [PATCH] builtin/describe: introduce --broken flag

2017-03-21 Thread Stefan Beller
On Tue, Mar 21, 2017 at 2:51 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> This patch helps to fix the root cause in [1], which tries to work around >> this situation. > > I do not necessarily think it is reasonable to give $version-dirty > and proceed when a repository corruption is det

Re: [PATCH] builtin/describe: introduce --broken flag

2017-03-21 Thread Junio C Hamano
Stefan Beller writes: > This patch helps to fix the root cause in [1], which tries to work around > this situation. I do not necessarily think it is reasonable to give $version-dirty and proceed when a repository corruption is detected; if there is a breakage in the repository, "git describe" is

[PATCH] builtin/describe: introduce --broken flag

2017-03-21 Thread Stefan Beller
git-describe tells you the version number you're at, or errors out, e.g. when you run it outside of a repository, which may happen when downloading a tar ball instead of using git to obtain the source code. To keep this property of only erroring out, when not in a repository, severe (submodule) er