Re: [PATCH] cache.h: move remote/connect API out of it

2013-07-08 Thread Junio C Hamano
Jeff King writes: > On Mon, Jul 08, 2013 at 02:09:59PM -0700, Junio C Hamano wrote: > >> The definition of "struct ref" in "cache.h", a header file so >> central to the system, always confused me. This structure is not >> about the local ref used by sha1-name API to name local objects. >> [...]

Re: [PATCH] cache.h: move remote/connect API out of it

2013-07-08 Thread Jeff King
On Mon, Jul 08, 2013 at 02:09:59PM -0700, Junio C Hamano wrote: > The definition of "struct ref" in "cache.h", a header file so > central to the system, always confused me. This structure is not > about the local ref used by sha1-name API to name local objects. > [...] > * I hate to to this kind

Re: [PATCH] cache.h: move remote/connect API out of it

2013-07-08 Thread Junio C Hamano
Junio C Hamano writes: > The definition of "struct ref" in "cache.h", a header file so > central to the system, always confused me. This structure is not > about the local ref used by sha1-name API to name local objects. > > It is what refspecs are expanded into, after finding out what refs > th

[PATCH] cache.h: move remote/connect API out of it

2013-07-08 Thread Junio C Hamano
The definition of "struct ref" in "cache.h", a header file so central to the system, always confused me. This structure is not about the local ref used by sha1-name API to name local objects. It is what refspecs are expanded into, after finding out what refs the other side has, to define what ref