Re: [PATCH] clone: local URLs are not for ssh

2013-10-15 Thread Torsten Bögershausen
On 15.10.13 02:12, Jeff King wrote: > On Sun, Oct 13, 2013 at 10:00:12PM +0200, Torsten Bögershausen wrote: > >> On 05.10.13 21:48, Torsten Bögershausen wrote: >>> On 2013-10-03 03.31, Jeff King wrote: http://article.gmane.org/gmane.comp.version-control.git/235473 >> What do we think a

Re: [PATCH] clone: local URLs are not for ssh

2013-10-14 Thread Jeff King
On Sun, Oct 13, 2013 at 10:00:12PM +0200, Torsten Bögershausen wrote: > On 05.10.13 21:48, Torsten Bögershausen wrote: > > On 2013-10-03 03.31, Jeff King wrote: > >> > >> http://article.gmane.org/gmane.comp.version-control.git/235473 > What do we think about extending the test a little bit: I n

Re: [PATCH] clone: local URLs are not for ssh

2013-10-13 Thread Torsten Bögershausen
On 05.10.13 21:48, Torsten Bögershausen wrote: > On 2013-10-03 03.31, Jeff King wrote: >> >> http://article.gmane.org/gmane.comp.version-control.git/235473 What do we think about extending the test a little bit: git diff 771cf1dab9303bab3c8198b8b6 -- t5602-clone-remote-exec.sh diff --git a/t/

Re: [PATCH] clone: local URLs are not for ssh

2013-10-05 Thread Matthieu Moy
Torsten Bögershausen writes: > test_expect_success 'cloning myhost:src uses ssh' ' > clear_ssh && > - git clone myhost:src ssh-clone && > + ! git clone myhost:src ssh-clone && This succeeds if Git segfaults for example. Please, use test_must_fail instead of "!". -- Matthie

Re: [PATCH] clone: local URLs are not for ssh

2013-10-05 Thread Torsten Bögershausen
On 2013-10-03 03.31, Jeff King wrote: > On Thu, Oct 03, 2013 at 08:01:23AM +0700, Nguyen Thai Ngoc Duy wrote: > >>> Sorry for the noise, I noticed it when I was trying to construct test cases. >>> >>> What do we think about adding this at the end of t5505: >> >> As usual more tests are usually bet

Re: [PATCH] clone: local URLs are not for ssh

2013-10-02 Thread Jeff King
On Thu, Oct 03, 2013 at 08:01:23AM +0700, Nguyen Thai Ngoc Duy wrote: > > Sorry for the noise, I noticed it when I was trying to construct test cases. > > > > What do we think about adding this at the end of t5505: > > As usual more tests are usually better. But is t5505-remote.sh the > best plac

Re: [PATCH] clone: local URLs are not for ssh

2013-10-02 Thread Duy Nguyen
On Thu, Oct 3, 2013 at 1:40 AM, Torsten Bögershausen wrote: > On 2013-09-29 02.33, Duy Nguyen wrote: >> On Sun, Sep 29, 2013 at 2:37 AM, Torsten Bögershausen wrote: >>> "git clone /foo/bar:baz" or "git clone ../foo/bar:baz" >>> are meant to clone from the local file system, and not to clone >>> f

Re: [PATCH] clone: local URLs are not for ssh

2013-10-02 Thread Torsten Bögershausen
On 2013-09-29 02.33, Duy Nguyen wrote: > On Sun, Sep 29, 2013 at 2:37 AM, Torsten Bögershausen wrote: >> "git clone /foo/bar:baz" or "git clone ../foo/bar:baz" >> are meant to clone from the local file system, and not to clone >> from a remote server over git-over-ssh. > > I don't think this is n

Re: [PATCH] clone: local URLs are not for ssh

2013-09-28 Thread Duy Nguyen
On Sun, Sep 29, 2013 at 2:37 AM, Torsten Bögershausen wrote: > "git clone /foo/bar:baz" or "git clone ../foo/bar:baz" > are meant to clone from the local file system, and not to clone > from a remote server over git-over-ssh. I don't think this is necessary. Commit 6000334 should detect both case

[PATCH] clone: local URLs are not for ssh

2013-09-28 Thread Torsten Bögershausen
"git clone /foo/bar:baz" or "git clone ../foo/bar:baz" are meant to clone from the local file system, and not to clone from a remote server over git-over-ssh. Signed-off-by: Torsten Bögershausen --- connect.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/connect.c b/conne