Re: [PATCH] commit: don't rewrite shared index unnecessarily

2015-08-31 Thread David Turner
On Mon, 2015-08-31 at 17:02 +0700, Duy Nguyen wrote: > On Fri, Aug 28, 2015 at 12:07 AM, David Turner > wrote: > > Remove a cache invalidation which would cause the shared index to be > > rewritten on as-is commits. > > > > When the cache-tree has changed, we need to update it. But we don't > >

Re: [PATCH] commit: don't rewrite shared index unnecessarily

2015-08-31 Thread Junio C Hamano
Duy Nguyen writes: > On Fri, Aug 28, 2015 at 12:07 AM, David Turner > wrote: >> Remove a cache invalidation which would cause the shared index to be >> rewritten on as-is commits. >> >> When the cache-tree has changed, we need to update it. But we don't >> necessarily need to update the shared

Re: [PATCH] commit: don't rewrite shared index unnecessarily

2015-08-31 Thread Duy Nguyen
On Fri, Aug 28, 2015 at 12:07 AM, David Turner wrote: > Remove a cache invalidation which would cause the shared index to be > rewritten on as-is commits. > > When the cache-tree has changed, we need to update it. But we don't > necessarily need to update the shared index. So setting > active_ca

[PATCH] commit: don't rewrite shared index unnecessarily

2015-08-27 Thread David Turner
Remove a cache invalidation which would cause the shared index to be rewritten on as-is commits. When the cache-tree has changed, we need to update it. But we don't necessarily need to update the shared index. So setting active_cache_changed to SOMETHING_CHANGED is unnecessary. Instead, we let