Re: [PATCH] commit: don't use-editor when allow-empty-message

Ramkumar Ramachandra wrote: > builtin/commit.c | 2 ++ > 1 file changed, 2 insertions(+) I just made this dependent on the order in which options are parsed. If --allow-empty-message is specified before -m "", it works. Otherwise, not. Sorry about the stupidity. -- To unsubscribe from this list:

[PATCH] commit: don't use-editor when allow-empty-message

Commit a24a41e (git-commit: only append a newline to -m mesg if necessary, 2013-02-18) introduced a regression: when --allow-empty-message is used and an empty message is explicitly specified with -m "", git commit still launches $EDITOR unnecessarily. The commit (correctly) fixes opt_parse_m() to