Re: [PATCH] commit-reach: cleanups in can_all_from_reach...

2018-09-25 Thread Junio C Hamano
Derrick Stolee writes: > Another commit walk that could be improved by generation numbers? It's > like my bat-signal! Ah, nevermind. The "traversal" done by these helper functions is the most stupid kind (not the algorthim, but the need). It's not like there is an opportunity to optimize by

Re: [PATCH] commit-reach: cleanups in can_all_from_reach...

2018-09-25 Thread Derrick Stolee
On 9/25/2018 2:06 PM, Junio C Hamano wrote: Derrick Stolee writes: @@ -622,10 +623,7 @@ int can_all_from_reach_with_flag(struct object_array *from, } cleanup: - for (i = 0; i < nr_commits; i++) { - clear_commit_marks(list[i], RESULT); -

Re: [PATCH] commit-reach: cleanups in can_all_from_reach...

2018-09-25 Thread Junio C Hamano
Derrick Stolee writes: > @@ -622,10 +623,7 @@ int can_all_from_reach_with_flag(struct object_array > *from, > } > > cleanup: > - for (i = 0; i < nr_commits; i++) { > - clear_commit_marks(list[i], RESULT); > - clear_commit_marks(list[i], assign_flag); > -

[PATCH] commit-reach: cleanups in can_all_from_reach...

2018-09-25 Thread Derrick Stolee
From: Derrick Stolee Due to a regression introduced by 4fbcca4e "commit-reach: make can_all_from_reach... linear" the series including b67f6b26 "commit-reach: properly peel tags" was merged to master quickly. There were a few more cleanups left to apply in the series, which are included by this