Re: [msysGit] [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

2015-04-23 Thread Johannes Schindelin
Hi Rupert, On 2015-04-23 21:25, rupert thurner wrote: > On Thursday, April 16, 2015 at 2:45:11 PM UTC+2, Johannes Schindelin wrote: >> >> However, using this code for `getppid()` would be serious overkill (not to >> mention an unbearable performance hit because you have to enumerate *all* >> proce

Re: [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

2015-04-16 Thread Luke Mewburn
On Wed, Apr 15, 2015 at 08:29:30PM +0200, Johannes Sixt wrote: | Windows does not have process groups. It is, therefore, the simplest | to pretend that each process is in its own process group. | | [...] | | diff --git a/compat/mingw.h b/compat/mingw.h | index 7b523cf..a552026 1006

Re: [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

2015-04-16 Thread Junio C Hamano
Johannes Schindelin writes: > On 2015-04-15 20:48, Junio C Hamano wrote: > >> The patch should do for now, but I suspect that it may give us a >> better abstraction to make the "is_foreground_fd(int fd)" or even >> "is_foreground(void)" the public API that would be implemented as >> >> int

Re: [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

2015-04-16 Thread Johannes Schindelin
Hi Junio, On 2015-04-15 20:48, Junio C Hamano wrote: > Johannes Sixt writes: > >> Windows does not have process groups. It is, therefore, the simplest >> to pretend that each process is in its own process group. >> >> While here, move the getppid() stub from its old location (between >> two sync

Re: [msysGit] [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

2015-04-16 Thread Johannes Schindelin
Hi kusma, On 2015-04-15 21:43, Erik Faye-Lund wrote: > On Wed, Apr 15, 2015 at 8:29 PM, Johannes Sixt wrote: >> Windows does not have process groups. It is, therefore, the simplest >> to pretend that each process is in its own process group. > > Windows does have some concept of process groups,

Re: [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

2015-04-15 Thread Johannes Sixt
Am 15.04.2015 um 20:48 schrieb Junio C Hamano: The patch should do for now, but I suspect that it may give us a better abstraction to make the "is_foreground_fd(int fd)" or even "is_foreground(void)" the public API that would be implemented as int we_are_in_the_foreground(void)

Re: [msysGit] [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

2015-04-15 Thread Erik Faye-Lund
On Wed, Apr 15, 2015 at 8:29 PM, Johannes Sixt wrote: > Windows does not have process groups. It is, therefore, the simplest > to pretend that each process is in its own process group. Windows does have some concept of process groups, but probably not quite what you want: https://msdn.microsoft.

Re: [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

2015-04-15 Thread Junio C Hamano
Johannes Sixt writes: > Windows does not have process groups. It is, therefore, the simplest > to pretend that each process is in its own process group. > > While here, move the getppid() stub from its old location (between > two sync related functions) next to the two new functions. > > Signed-o

[PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

2015-04-15 Thread Johannes Sixt
Windows does not have process groups. It is, therefore, the simplest to pretend that each process is in its own process group. While here, move the getppid() stub from its old location (between two sync related functions) next to the two new functions. Signed-off-by: Johannes Sixt --- compat/mi