Re: [PATCH] completion: include PARSE_OPT_HIDDEN in completion output

2018-08-17 Thread Duy Nguyen
On Thu, Aug 16, 2018 at 8:42 PM Ævar Arnfjörð Bjarmason wrote: > > The PARSE_OPT_HIDDEN is, per the documentation of the "option" struct > in option parse-options.h, only supposed to affect -h output, not > completion. That's what the PARSE_OPT_NOCOMPLETE flag is supposed to > be for. > > Since

Re: [PATCH] completion: include PARSE_OPT_HIDDEN in completion output

2018-08-16 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > However, manually going over: > > git grep -e OPT_HIDDEN_BOOL -e PARSE_OPT_HIDDEN > > Shows many options we don't want to show in completion either, > e.g. "git am --binary" or "git branch -l". Many of these are internal, > deprecated, or no-ops. There's

[PATCH] completion: include PARSE_OPT_HIDDEN in completion output

2018-08-16 Thread Ævar Arnfjörð Bjarmason
The PARSE_OPT_HIDDEN is, per the documentation of the "option" struct in option parse-options.h, only supposed to affect -h output, not completion. That's what the PARSE_OPT_NOCOMPLETE flag is supposed to be for. Since 2e29dca66a ("completion: use __gitcomp_builtin in _git_commit", 2018-02-09)