Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override

Lars Schneider writes: > If the clean/smudge command of a Git filter driver (filter..smudge and > filter..clean) is set to an empty string ("") and the filter driver is > not required (filter..required=false) then Git will run successfully. > However, Git will print an

Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override

larsxschnei...@gmail.com writes: > - if (ca.drv) { > + if (ca.drv && ca.drv->smudge && strlen(ca.drv->smudge)) { You are not interested in its length, but if it is an empty string or not, so I'd tweak this like so: > + if (ca.drv && ca.drv->smudge && *ca.drv->smudge) { -- To

Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override

On 25 Jan 2016, at 02:25, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> >> A clean/smudge filter can be disabled if set to an empty string. However, >> Git will try to run the empty string as command which

Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override

On 24 Jan 2016, at 22:45, Jeff King wrote: > On Sun, Jan 24, 2016 at 01:22:50PM +0100, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider >> >> A clean/smudge filter can be disabled if set to an empty string. However, >> Git will try to run the

Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override

On 24 Jan 2016, at 22:35, Eric Sunshine wrote: > On Sun, Jan 24, 2016 at 10:06 AM, Torsten Bögershausen wrote: >> On 24.01.16 13:22, larsxschnei...@gmail.com wrote: >>> From: Lars Schneider >>> diff --git a/convert.c

Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override

On 24 Jan 2016, at 16:06, Torsten Bögershausen wrote: > On 24.01.16 13:22, larsxschnei...@gmail.com wrote: >> From: Lars Schneider > Some minor nits inside: >> >> A clean/smudge filter can be disabled if set to an empty string. > "set to an empty

Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override

larsxschnei...@gmail.com writes: > From: Lars Schneider > > A clean/smudge filter can be disabled if set to an empty string. However, > Git will try to run the empty string as command which results in a error > message per processed file. The above two sentences do not

[PATCH] convert: legitimately disable clean/smudge filter with an empty override

From: Lars Schneider A clean/smudge filter can be disabled if set to an empty string. However, Git will try to run the empty string as command which results in a error message per processed file. Teach Git to consider an empty clean/smudge filter as legitimately

Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override

On 24.01.16 13:22, larsxschnei...@gmail.com wrote: > From: Lars Schneider Some minor nits inside: > > A clean/smudge filter can be disabled if set to an empty string. "set to an empty string" refers to "git config" (in opposite to the filter as such, which is

Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override

On Sun, Jan 24, 2016 at 01:22:50PM +0100, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > A clean/smudge filter can be disabled if set to an empty string. However, > Git will try to run the empty string as command which results in a error > message per

Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override

On Sun, Jan 24, 2016 at 10:06 AM, Torsten Bögershausen wrote: > On 24.01.16 13:22, larsxschnei...@gmail.com wrote: >> From: Lars Schneider >> diff --git a/convert.c b/convert.c >> @@ -786,7 +786,7 @@ int convert_to_git(const char *path, const char *src,