Re: [PATCH] correct FLEXPTR_* example in comment

On Sat, Aug 13, 2016 at 07:26:02PM +0200, René Scharfe wrote: > > I suppose it could assert(sizeof((x)->flexname) == FLEX_ALLOC) or > > something, but I'm not sure if it is worth worrying about. > > You can't use sizeof with an actual flexible array. It only works if > FLEX_ARRAY is defined as

Re: [PATCH] correct FLEXPTR_* example in comment

Am 13.08.2016 um 11:09 schrieb Jeff King: On Sat, Aug 13, 2016 at 11:01:21AM +0200, René Scharfe wrote: This section is about "The FLEXPTR_* variants", so use FLEXPTR_ALLOC_STR in the example. Oops, yeah. Your patch is clearly an improvement. Since this is obviously an easy mistake to make

Re: [PATCH] correct FLEXPTR_* example in comment

Am 13.08.2016 um 11:09 schrieb Jeff King: On Sat, Aug 13, 2016 at 11:01:21AM +0200, René Scharfe wrote: This section is about "The FLEXPTR_* variants", so use FLEXPTR_ALLOC_STR in the example. Oops, yeah. Your patch is clearly an improvement. Since this is obviously an easy mistake to make

Re: [PATCH] correct FLEXPTR_* example in comment

On Sat, Aug 13, 2016 at 11:01:21AM +0200, René Scharfe wrote: > This section is about "The FLEXPTR_* variants", so use FLEXPTR_ALLOC_STR > in the example. Oops, yeah. Your patch is clearly an improvement. Since this is obviously an easy mistake to make (using one form rather than the other), I

[PATCH] correct FLEXPTR_* example in comment

This section is about "The FLEXPTR_* variants", so use FLEXPTR_ALLOC_STR in the example. Signed-off-by: Rene Scharfe --- git-compat-util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-compat-util.h b/git-compat-util.h index 590bfdd..f52e00b 100644 ---