Re: [PATCH] crlf: Add test showing double warning on commit

Torsten Bögershausen writes: > Nja, (Or Nyes in English), the old handling tried to be "nice" to the user: > $ git add text # gave warning > #User forgets, does other things, git reset HEAD > $ git commit # Gave the warning one more time, to remind the user, > #

Re: [PATCH] crlf: Add test showing double warning on commit

On 14.05.16 20:45, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> Do we need to run diff_populate_filespec() twice when src==dst ? > > Of course we do. > > src and dst may have the same path, but are coming from different > places (src may be an indexed blob while dst

Re: [PATCH] crlf: Add test showing double warning on commit

On 14.05.16 20:45, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> Do we need to run diff_populate_filespec() twice when src==dst ? > > Of course we do. > > src and dst may have the same path, but are coming from different > places (src may be an indexed blob while dst

Re: [PATCH] crlf: Add test showing double warning on commit

Torsten Bögershausen writes: > Do we need to run diff_populate_filespec() twice when src==dst ? Of course we do. src and dst may have the same path, but are coming from different places (src may be an indexed blob while dst may be a file in the working tree). > If yes, we may

[PATCH] crlf: Add test showing double warning on commit

Add failing test case showing CRLF -> LF rewrite warnings being printed multiple times when running "git commit". Signed-off-by: Adam Dinwoodie --- t/t0020-crlf.sh | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/t/t0020-crlf.sh