Am 07.03.2015 um 02:08 schrieb Jeff King:
On Sat, Mar 07, 2015 at 01:20:22AM +0100, René Scharfe wrote:
Not a big deal, but do we want to rename sanitize_client_strbuf to
sanitize_client? It only had the unwieldy name to distinguish it from
this one.
A patch would look like this. The result
On Sat, Mar 07, 2015 at 01:20:22AM +0100, René Scharfe wrote:
> > Not a big deal, but do we want to rename sanitize_client_strbuf to
> > sanitize_client? It only had the unwieldy name to distinguish it from
> > this one.
>
> A patch would look like this. The result is shorter, but no win in
> te
On Sat, Mar 07, 2015 at 01:54:12AM +0100, René Scharfe wrote:
> >These probably want to all be strbuf_release(). Again, I doubt it
> >matters much because this is a forked daemon serving only a single
> >request (so they'll get freed by the OS soon anyway), but I think
> >freeing the memory here f
Am 06.03.2015 um 22:06 schrieb Jeff King:
On Fri, Mar 06, 2015 at 09:57:22AM +0100, René Scharfe wrote:
if (port) {
- free(tcp_port);
- tcp_port = sanitize_client(port);
+
Am 06.03.2015 um 22:06 schrieb Jeff King:
> On Fri, Mar 06, 2015 at 09:57:22AM +0100, René Scharfe wrote:
>
>> Convert hostname, canon_hostname, ip_address and tcp_port to strbuf.
>> This allows to get rid of the helpers strbuf_addstr_or_null() and STRARG
>> because a strbuf always represents a va
On Fri, Mar 06, 2015 at 09:57:22AM +0100, René Scharfe wrote:
> Convert hostname, canon_hostname, ip_address and tcp_port to strbuf.
> This allows to get rid of the helpers strbuf_addstr_or_null() and STRARG
> because a strbuf always represents a valid (initially empty) string.
> sanitize_client()
Convert hostname, canon_hostname, ip_address and tcp_port to strbuf.
This allows to get rid of the helpers strbuf_addstr_or_null() and STRARG
because a strbuf always represents a valid (initially empty) string.
sanitize_client() becomes unused and is removed as well.
Signed-off-by: Rene Scharfe
-
7 matches
Mail list logo
